Skip to content

fix: split MOBB_EXEC from MOBB_ARGS for test tooling compatibility [E-1815] #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathansantilli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: split MOBB_EXEC from MOBB_ARGS for test tooling compatibility [E-1815] #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,11 @@ runs:
echo "REPO: $REPO"
echo "BRANCH: $BRANCH"

# npx --yes mobbdev@latest is kept on its own line so test tooling
# (autofixer CI) can sed-replace it with a local build command.
MOBB_EXEC=(npx --yes mobbdev@latest)
MOBB_ARGS=(
npx --yes mobbdev@latest analyze --ci
analyze --ci
-r "$REPO"
--ref "$BRANCH"
--api-key "$MOBB_API_KEY"
Expand Down Expand Up @@ -86,7 +89,7 @@ runs:
fi
fi

OUT=$(env "${MOBB_ARGS[@]}")
OUT=$(env "${MOBB_EXEC[@]}" "${MOBB_ARGS[@]}")

RETVAL=$?
if [ $RETVAL -ne 0 ]; then
Expand Down
7 changes: 5 additions & 2 deletions review/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,11 @@ runs:
echo "COMMIT_HASH: $COMMIT_HASH"
echo "PR_NUMBER: $PR_NUMBER"

# npx --yes mobbdev@latest is kept on its own line so test tooling
# (autofixer CI) can sed-replace it with a local build command.
MOBB_EXEC=(npx --yes mobbdev@latest)
MOBB_ARGS=(
npx --yes mobbdev@latest review
review
-r "$REPO"
--ref "$GITHUB_HEAD_REF"
--ch "$COMMIT_HASH"
Expand All @@ -80,7 +83,7 @@ runs:
MOBB_ARGS+=(--mobb-project-name "$MOBB_PROJECT_NAME")
fi

OUT=$(env "${MOBB_ARGS[@]}" || true)
OUT=$(env "${MOBB_EXEC[@]}" "${MOBB_ARGS[@]}" || true)
OUT=$(echo "$OUT" | tr '\n' ' ')
MOBB_URL=$(echo "$OUT" | grep -oE 'https://[^ ]+' | head -1)

Expand Down
Loading