Skip to content

Conversation

@clarmso
Copy link
Collaborator

@clarmso clarmso commented Nov 3, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Let me use this PR to see which unit tests and smoke tests that need updates.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@clarmso clarmso added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 3, 2025
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 3, 2025

Messages
📖 Project coverage: 39.0%

💪 Quality guardian

1 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Client.app: Coverage: 37.15

File Coverage
SearchEngineFlagManager.swift 75.0%

Generated by 🚫 Danger Swift against 705e821

@clarmso clarmso force-pushed the cs/MTE-4982-fix-ui-tests branch 2 times, most recently from 85cbc0d to ecfb70e Compare November 6, 2025 19:19
@clarmso clarmso force-pushed the cs/MTE-4982-fix-ui-tests branch from ecfb70e to 6174fd8 Compare November 10, 2025 16:09
@clarmso clarmso marked this pull request as ready for review November 10, 2025 20:47
@clarmso clarmso requested review from a team as code owners November 10, 2025 20:47
app.tables.cells.element(boundBy: 0).waitAndTap()
let tablesQuery2 = app.tables
tablesQuery2.staticTexts[searchEngine].waitAndTap()
tablesQuery2.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", searchEngine)).element.waitAndTap()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wikipedia" now appears as "Wikipedia (en)" in the list of search engines.

@clarmso
Copy link
Collaborator Author

clarmso commented Nov 10, 2025

@mattreaganmozilla I found no new test failures from the full functional tests. Just one updates from a smoke test (testSearchEngine()).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants