Skip to content

Update FXIOS-13834 UI test #30351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+6 −4
Open

Update FXIOS-13834 UI test #30351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fd4a5be
Remove flag
clarmso Nov 3, 2025
fcc577a
disable testQuickSearchEngines
clarmso Nov 3, 2025
a9bd6f6
Just deal with the UI tests for now. Don't worry about unit tests
clarmso Nov 5, 2025
8ee179b
fix comment?
clarmso Nov 5, 2025
4792691
oops syntax error
clarmso Nov 5, 2025
6174fd8
Enable sec on xcuitests
clarmso Nov 6, 2025
705e821
"Wikipedia" search engine now lists as "Wikipedia (en)"
clarmso Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions firefox-ios/Client/Frontend/Browser/SearchEngines/SearchEngineFlagManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@ import Common
struct SearchEngineFlagManager {
/// Whether Search Engine Consolidation is enabled.
/// If enabled, search engines are fetched from Remote Settings rather than our pre-bundled XML files.
/// TODO: [FXIOS-13834 & 11403] Remove hardcoded override once UI & unit tests are updated (or deleted)
static var isSECEnabled: Bool {
// TODO: [FXIOS-13834 & 11403] Remove hardcoded override once UI & unit tests are updated (or deleted)
guard !AppConstants.isRunningUnitTest && !AppConstants.isRunningUITests else { return false }

// If you want to disable during unit tests, do it here:
if AppConstants.isRunningUnitTest {
return false
}
// SEC enabled for all users. Related clean-up forthcoming in [FXIOS-11403].
return true
}
Expand Down
2 changes: 1 addition & 1 deletion firefox-ios/firefox-ios-tests/Tests/XCUITests/SearchTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ class SearchTests: FeatureFlaggedTestBase {
// Open the list of default search engines and select the desired
app.tables.cells.element(boundBy: 0).waitAndTap()
let tablesQuery2 = app.tables
tablesQuery2.staticTexts[searchEngine].waitAndTap()
tablesQuery2.staticTexts.containing(NSPredicate(format: "label CONTAINS[c] %@", searchEngine)).element.waitAndTap()
Copy link
Collaborator Author

@clarmso clarmso Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Wikipedia" now appears as "Wikipedia (en)" in the list of search engines.

Copy link
Collaborator

@mattreaganmozilla mattreaganmozilla Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the name has changed between the bundled engine and the Wikipedia entries on RS (so that's expected)

Copy link
Collaborator

@dragosb01 dragosb01 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarmso we already have a function that checks if an element contains some text.
You can simply use tablesQuery2.staticTexts.elementContainingText(searchEngine).waitAndTap()
I have tested locally and it works


navigator.goto(HomePanelsScreen)
navigator.goto(URLBarOpen)
Expand Down