Skip to content

Page settings: relax page number offset limits#33321

Merged
RomanPudashkin merged 1 commit into
musescore:mainfrom
cbjeukendrup:page-settings-relax-page-offset-limit
May 14, 2026
Merged

Page settings: relax page number offset limits#33321
RomanPudashkin merged 1 commit into
musescore:mainfrom
cbjeukendrup:page-settings-relax-page-offset-limit

Conversation

@cbjeukendrup
Copy link
Copy Markdown
Collaborator

Allow any number from -999999 to 999999, because there is not really any reason to put any limit.

Resolves: #33188

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 961f3cf7-3981-40ef-9aae-8ba8bf82652f

📥 Commits

Reviewing files that changed from the base of the PR and between 0b12fa5 and 53dc950.

📒 Files selected for processing (1)
  • src/notationscene/widgets/pagesettings.ui

📝 Walkthrough

Walkthrough

This pull request expands the input range of the pageOffsetEntry spin box widget in the page settings dialog. The minimum bound increases from -99 to -999999 and the maximum bound increases from 999 to 999999, allowing users to specify page offsets across a significantly wider range while preserving all other widget properties and behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the issue resolution link and motivation, but is missing most required template sections like CLA signature confirmation and checklist items. Complete the PR description template by filling out or confirming the checklist items regarding CLA, title, commit messages, code quality, testing, and compilation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Page settings: relax page number offset limits' clearly and specifically describes the main change made in the pull request.
Linked Issues check ✅ Passed The PR successfully addresses the linked issue #33188 by expanding the page offset limits from [-99, 999] to [-999999, 999999], allowing four-digit and larger values as requested.
Out of Scope Changes check ✅ Passed All changes are directly related to the objective of relaxing page number offset limits; the QSpinBox range modification is the sole change with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Allow any number from -999999 to 999999, because there is not really any reason to put any limit.

Resolves: musescore#33188
@davidstephengrant
Copy link
Copy Markdown
Contributor

@cbjeukendrup Please, can you rebase.

@cbjeukendrup cbjeukendrup force-pushed the page-settings-relax-page-offset-limit branch from 53dc950 to 11c7208 Compare May 13, 2026 10:30
@cbjeukendrup
Copy link
Copy Markdown
Collaborator Author

Done!

@davidstephengrant
Copy link
Copy Markdown
Contributor

@RomanPudashkin Tested and approved on Ubuntu 24.04.4 LTS.

@RomanPudashkin RomanPudashkin changed the base branch from master to main May 14, 2026 08:34
@RomanPudashkin RomanPudashkin merged commit e8df477 into musescore:main May 14, 2026
13 of 14 checks passed
@RomanPudashkin RomanPudashkin deleted the page-settings-relax-page-offset-limit branch May 14, 2026 08:34
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relax 3-digit limit for first page number

4 participants