[4.7.0] Fix #32000: Some Style Dropdown menus colors a bit dark on Windows

[RomanPudashkin]

Resolves: #32000

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[RomanPudashkin]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR modifies the ComboBoxDropdown QML component to implement a custom popup instead of relying on default behavior. The popup constrains its width to match the combo box width and its height to the smaller of the content height or available window space. The popup removes default padding, applies the theme's accent color as the background, and renders dropdown items through a StyledListView component wired to the combo box's delegate model with selection driven by the highlighted index.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is minimal but complies with the template by including the resolved issue link; however, it lacks detail about the change and only partially fills the PR template.
Linked Issues check	✅ Passed	The code change implements a custom ComboBox popup with theme-aware background color to fix the dark dropdown appearance on Windows light mode, directly addressing issue #32000.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to ComboBoxDropdown.qml with only 18 lines added to customize the popup styling, directly relevant to fixing the reported dropdown color issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: fixing dropdown menu colors on Windows. It directly references the issue (#32000) and specifies the UI problem being resolved.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/notationscene/qml/MuseScore/NotationScene/styledialog/ComboBoxDropdown.qml`:
- Around line 147-149: Change the popup background color to use the neutral
button color instead of the accent/brand color: in the ComboBoxDropdown QML
component replace the background Rectangle's color reference from
ui.theme.accentColor to ui.theme.buttonColor so the popup background matches the
combobox button and delegate items (ensure the same token used at the combobox
button and delegate is applied to the background Rectangle).
- Line 143: The popup height cap currently uses comboDropdown.Window.height
which ignores the combobox Y offset; fix by computing available space above and
below the combobox in window coordinates and cap to the larger of those spaces.
In ComboBoxDropdown.qml replace use of comboDropdown.Window.height with a
calculation using comboDropdown.mapToItem(null, 0, 0).y (or
comboDropdown.mapToGlobal if you need screen coords) to get the combobox top in
window/screen space, then compute availableBottom = comboDropdown.Window.height
- comboboxY and availableTop = comboboxY, and set height:
Math.min(contentItem.implicitHeight, Math.max(availableTop, availableBottom)) so
the popup never exceeds visible area.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e168b687-fb46-459b-bd85-f28e45b67ff7

📥 Commits

Reviewing files that changed from the base of the PR and between 98ab667 and 3beafd6.

📒 Files selected for processing (1)

• src/notationscene/qml/MuseScore/NotationScene/styledialog/ComboBoxDropdown.qml

[zacjansheski]

Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved
#32000 FIXED