Write at the logical position after buffered reads - #163
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the public file position for writes and invalidate readahead after a successful nonempty write. Failed and empty writes preserve the buffered state.
Reproduction
With a remote file containing
abcdef, openr+, callread(2),write("XY"), thenread(2). Baseline writes at offset 6, producesabcdefXY, and jumps to position 8. Fixed writes at offset 2, producesabXYef, leaves position 4, and returnsefon the following read.Verification
/usr/libexec/sftp-serverpipe.Breaking changes and limitations
Intentional correction: callers relying on the incorrect readahead offset will now write at the documented logical position. Empty-write behavior and write-error identity remain preserved. This does not add append-mode cursor tracking. Existing PRs #161/#162 already propose bytesize; this PR leaves that optimization separate.
No repository tests were added or modified under the contribution's no-new-tests constraint; focused repro/model drivers ran outside the repository. An external verification Gemfile supplies compatible test tools and RDoc without changing upstream tooling. Actual older Ruby/JRuby/Windows compatibility and upstream CI have not been verified. No production or SSH connections, version bumps, release-tool changes or unrelated modernization are included. Git builds are not signed by the upstream gem release key.