Skip to content

A set of possible enhancements or other bits#4

Draft
jfm535 wants to merge 1 commit intonot-wlan:masterfrom
jfm535:Enhancements
Draft

A set of possible enhancements or other bits#4
jfm535 wants to merge 1 commit intonot-wlan:masterfrom
jfm535:Enhancements

Conversation

@jfm535
Copy link
Copy Markdown
Contributor

@jfm535 jfm535 commented Jul 25, 2021

this is a misc list of additional code pieces with sources included (do not immedately merge cosider this atm more of a cherrypick area for now)

InfoBuilder.setHashPDBContentsToGUID(false);
InfoBuilder.setSignature(Signature);
InfoBuilder.setGuid(OurGuid);
InfoBuilder.addFeature(llvm::pdb::PdbRaw_FeatureSig::VC140);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what this does?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well no but it seems to be important when merging pdbs and comes from this enum

enum class PdbRaw_FeatureSig : uint32_t {
  VC110 = PdbImplVC110,
  VC140 = PdbImplVC140,
  NoTypeMerge = 0x4D544F4E,
  MinimalDebugInfo = 0x494E494D,
};

so my best guess it tells the pdb how to expect the data.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its also seems connected with this data

enum PdbRaw_Features : uint32_t {
  PdbFeatureNone = 0x0,
  PdbFeatureContainsIdStream = 0x1,
  PdbFeatureMinimalDebugInfo = 0x2,
  PdbFeatureNoTypeMerging = 0x4,
  LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue = */ PdbFeatureNoTypeMerging)
};

@jfm535
Copy link
Copy Markdown
Contributor Author

jfm535 commented Jul 25, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants