A set of possible enhancements or other bits#4
Draft
jfm535 wants to merge 1 commit intonot-wlan:masterfrom
Draft
A set of possible enhancements or other bits#4jfm535 wants to merge 1 commit intonot-wlan:masterfrom
jfm535 wants to merge 1 commit intonot-wlan:masterfrom
Conversation
jfm535
commented
Jul 25, 2021
| InfoBuilder.setHashPDBContentsToGUID(false); | ||
| InfoBuilder.setSignature(Signature); | ||
| InfoBuilder.setGuid(OurGuid); | ||
| InfoBuilder.addFeature(llvm::pdb::PdbRaw_FeatureSig::VC140); |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
well no but it seems to be important when merging pdbs and comes from this enum
enum class PdbRaw_FeatureSig : uint32_t {
VC110 = PdbImplVC110,
VC140 = PdbImplVC140,
NoTypeMerge = 0x4D544F4E,
MinimalDebugInfo = 0x494E494D,
};
so my best guess it tells the pdb how to expect the data.
Contributor
Author
There was a problem hiding this comment.
its also seems connected with this data
enum PdbRaw_Features : uint32_t {
PdbFeatureNone = 0x0,
PdbFeatureContainsIdStream = 0x1,
PdbFeatureMinimalDebugInfo = 0x2,
PdbFeatureNoTypeMerging = 0x4,
LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue = */ PdbFeatureNoTypeMerging)
};
Contributor
Author
|
this is created also where i might attempt to solve the issue of c++ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a misc list of additional code pieces with sources included (do not immedately merge cosider this atm more of a cherrypick area for now)