Skip to content

A set of possible enhancements or other bits #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jfm535 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

A set of possible enhancements or other bits #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libllvm-pdb-wrapper/wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ bool pdb_file::initialize(bool is_64bit ,uint32_t Age,uint32_t Signature,llvm::c
InfoBuilder.setHashPDBContentsToGUID(false);
InfoBuilder.setSignature(Signature);
InfoBuilder.setGuid(OurGuid);
InfoBuilder.addFeature(llvm::pdb::PdbRaw_FeatureSig::VC140);
Copy link
Copy Markdown
Contributor Author

@jfm535 jfm535 Jul 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from here https://github.com/llvm/llvm-project/blob/8ba9ee46e465a56a54f8361703d3af7f4bc98d63/llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp#L1335

Copy link
Copy Markdown
Owner

@not-wlan not-wlan Jul 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what this does?

Copy link
Copy Markdown
Contributor Author

@jfm535 jfm535 Jul 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well no but it seems to be important when merging pdbs and comes from this enum

enum class PdbRaw_FeatureSig : uint32_t {
  VC110 = PdbImplVC110,
  VC140 = PdbImplVC140,
  NoTypeMerge = 0x4D544F4E,
  MinimalDebugInfo = 0x494E494D,
};

so my best guess it tells the pdb how to expect the data.

Copy link
Copy Markdown
Contributor Author

@jfm535 jfm535 Jul 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its also seems connected with this data

enum PdbRaw_Features : uint32_t {
  PdbFeatureNone = 0x0,
  PdbFeatureContainsIdStream = 0x1,
  PdbFeatureMinimalDebugInfo = 0x2,
  PdbFeatureNoTypeMerging = 0x4,
  LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue = */ PdbFeatureNoTypeMerging)
};

//Add an empty DBI stream.
auto &DbiBuilder = m_pdb_builder->getDbiBuilder();
DbiBuilder.setAge(InfoBuilder.getAge());
Expand Down