Skip to content

feat: remove end time column from traces table - #785

Merged
akila-i merged 1 commit into
openchoreo:mainfrom
Brilly-Bohyun:feature/remove-end-time-traces
Sep 14, 2026
Merged

feat: remove end time column from traces table#785
akila-i merged 1 commit into
openchoreo:mainfrom
Brilly-Bohyun:feature/remove-end-time-traces

Conversation

@Brilly-Bohyun

@Brilly-Bohyun Brilly-Bohyun commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

The traces table shows start time, end time, and duration, making rows
cluttered. Start time and duration provide sufficient timing information.

Resolves openchoreo/openchoreo#4704

Goals

Remove the redundant End Time column and make trace names easier to read.

Approach

  • Remove the End Time header, row cell, and column sizing entry.
  • Increase the Trace Name column width from 12% to 32%.
  • Preserve end-time data and the span detail view.
  • Add a patch changeset for the observability plugin.
스크린샷 2026-09-10 오후 8 25 05 Verified in the Portal's Catalog → Traces page using two mock traces. The temporary mock setup is not included in this PR.

User stories

Users can read longer trace names without redundant timestamps cluttering the traces table.

Release note

Removed the End Time column from the traces table and widened the Trace Name column.

Documentation

N/A — no configuration or workflow changes.

Training

N/A

Certification

N/A — presentation-only change.

Marketing

N/A

Automation tests

  • All 10 TracesTable tests passed, including a regression test verifying that the End Time header and value are not displayed.
  • Manually verified the Catalog → Traces page with two mock traces.

Security checks

Samples

N/A

Related PRs

openchoreo/openchoreo#4704

Migrations (if applicable)

N/A

Test environment

macOS, local Chrome browser

Learning

The table header and rows share column sizing through getColumnStyle.

Summary by CodeRabbit

  • Improvements
    • Removed the End Time column from the traces table for a simpler view.
    • Widened the Trace Name column to improve readability.
  • Bug Fixes
    • Updated trace table behavior to ensure end-time headers and values are no longer displayed.

Signed-off-by: Brilly-Bohyun <102973953+Brilly-Bohyun@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b4e8c8eb-f62a-4ef8-a11a-9744e8e32a0a

📥 Commits

Reviewing files that changed from the base of the PR and between cc2fe12 and 1d6e70c.

📒 Files selected for processing (4)
  • .changeset/fiery-sloths-shout.md
  • plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx
  • plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx
  • plugins/openchoreo-observability/src/components/Traces/columns.ts
💤 Files with no reviewable changes (1)
  • plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The traces table removes the End Time column and its values. The Trace Name column expands from 12% to 32%. Tests verify the updated headers and row content. A patch changeset records the package update.

Changes

Traces table update

Layer / File(s) Summary
Column contract and layout
plugins/openchoreo-observability/src/components/Traces/columns.ts
The TracesColumn type removes endTime. The column style widens traceName to 32%.
Table rendering and validation
plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx, plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx, .changeset/fiery-sloths-shout.md
The table no longer renders End Time headers or values. Tests verify the omission. A patch changeset records the update.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 1d6e7

The traces table now hides redundant End Time information and gives Trace Name more space without removing trace details. The focused test coverage confirms the intended UI behavior, so this change is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: removing the End Time column from the traces table.
Description check ✅ Passed The description covers the purpose, goals, approach, user story, release note, documentation, testing, security, and environment details. It is complete enough for this UI-only change.
Linked Issues check ✅ Passed The implementation satisfies issue #4704 by removing the End Time column and extending the Trace Name column. It preserves end-time data and span details as required by the PR objectives.
Out of Scope Changes check ✅ Passed All changes are directly related to issue #4704 and the stated objectives. The code, regression test, column sizing update, and patch changeset are in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@akila-i
akila-i merged commit 97be767 into openchoreo:main Sep 14, 2026
9 checks passed
@akila-i

akila-i commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution @Brilly-Bohyun !

@Brilly-Bohyun

Copy link
Copy Markdown
Contributor Author

@nilushancosta @stefinie123 @akila-i Thanks for reviewing and merging! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the End Time column from the traces view

4 participants