feat: remove end time column from traces table - #785
Conversation
Signed-off-by: Brilly-Bohyun <102973953+Brilly-Bohyun@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe traces table removes the End Time column and its values. The Trace Name column expands from 12% to 32%. Tests verify the updated headers and row content. A patch changeset records the package update. ChangesTraces table update
Estimated code review effort: 1 (Trivial) | ~5 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The traces table now hides redundant End Time information and gives Trace Name more space without removing trace details. The focused test coverage confirms the intended UI behavior, so this change is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks for the contribution @Brilly-Bohyun ! |
|
@nilushancosta @stefinie123 @akila-i Thanks for reviewing and merging! 🙌 |
Purpose
The traces table shows start time, end time, and duration, making rows
cluttered. Start time and duration provide sufficient timing information.
Resolves openchoreo/openchoreo#4704
Goals
Remove the redundant End Time column and make trace names easier to read.
Approach
User stories
Users can read longer trace names without redundant timestamps cluttering the traces table.
Release note
Removed the End Time column from the traces table and widened the Trace Name column.
Documentation
N/A — no configuration or workflow changes.
Training
N/A
Certification
N/A — presentation-only change.
Marketing
N/A
Automation tests
Security checks
Samples
N/A
Related PRs
openchoreo/openchoreo#4704
Migrations (if applicable)
N/A
Test environment
macOS, local Chrome browser
Learning
The table header and rows share column sizing through getColumnStyle.
Summary by CodeRabbit