Skip to content

feat: remove end time column from traces table #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akila-i merged 1 commit into from
Sep 14, 2026
Merged

feat: remove end time column from traces table #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fiery-sloths-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openchoreo/backstage-plugin-openchoreo-observability': patch
---

Remove the End Time column from the traces table and widen the Trace Name column.
9 changes: 8 additions & 1 deletion plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ describe('TracesTable', () => {

expect(screen.getByText('Trace Name')).toBeInTheDocument();
expect(screen.getByText('Start Time')).toBeInTheDocument();
expect(screen.getByText('End Time')).toBeInTheDocument();
expect(screen.getByText('Duration')).toBeInTheDocument();
expect(screen.getByText('Number of Spans')).toBeInTheDocument();
expect(screen.getByText('Details')).toBeInTheDocument();
Expand Down Expand Up @@ -157,4 +156,12 @@ describe('TracesTable', () => {

expect(container.querySelector('[class*="errorStripe"]')).toBeNull();
});

// Start time and duration provide enough timing information without cluttering the table.
it('does not display end time in the traces table', () => {
renderTable();

expect(screen.queryByText('End Time')).not.toBeInTheDocument();
expect(screen.queryByText(sampleTrace.endTime)).not.toBeInTheDocument();
});
});
7 changes: 0 additions & 7 deletions plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ const HEADER_COLUMNS: {
}[] = [
{ key: 'traceName', label: 'Trace Name' },
{ key: 'startTime', label: 'Start Time' },
{ key: 'endTime', label: 'End Time' },
{ key: 'duration', label: 'Duration' },
{ key: 'spanCount', label: 'Number of Spans' },
{ key: 'details', label: 'Details', align: 'right' },
Expand Down Expand Up @@ -152,12 +151,6 @@ export const TracesTable: FC<TracesTableProps> = ({
>
{trace.startTime}
</Box>
<Box
style={getColumnStyle('endTime')}
className={`${classes.cell} ${classes.traceCell}`}
>
{trace.endTime}
</Box>
<Box
style={getColumnStyle('duration')}
className={`${classes.cell} ${classes.traceCell}`}
Expand Down
4 changes: 1 addition & 3 deletions plugins/openchoreo-observability/src/components/Traces/columns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { makeColumnStyle } from '@openchoreo/backstage-plugin-react';
export type TracesColumn =
| 'traceName'
| 'startTime'
| 'endTime'
| 'duration'
| 'spanCount'
| 'details';
Expand All @@ -19,9 +18,8 @@ export type TracesColumn =
* total (88%) leaves the same trailing whitespace MUI's table did.
*/
export const getColumnStyle = makeColumnStyle<TracesColumn>({
traceName: '0 0 12%',
traceName: '0 0 32%',
startTime: '0 0 20%',
endTime: '0 0 20%',
duration: '0 0 12%',
spanCount: '0 0 12%',
details: '0 0 12%',
Expand Down
Loading