fix: point to new models in channel_migrations app #37654
Conversation
| setup_retirement_states | ||
| ) | ||
|
|
||
| # This is a temporary import path while we transition from integrated_channels to channel_integrations |
There was a problem hiding this comment.
could you add a timeline or link to a publicly available ticket to this comment?
There was a problem hiding this comment.
We don't have a publicly available ticket but this will be done as soon as we can test the changes on edx/edx-platform repo and confirm everything is working.
There was a problem hiding this comment.
Could you add this to the core settings file opened/envs/common.py and add a full toggle annotation? By keeping all of our settings in the central envs/ files, it helps us keep track of them and document them. And as Deborah mentioned pleased create an edx-platform GitHub issue and include a link to it in the .. toggle_tickets. You can declare the default as True there.
Furthermore, please access the setting directly (settings.ENABLE_LEGACY_INTEGRATED_CHANNELS) in all places instead of using getattr. This way, we will get a helpful exception if the setting name is misspelled or if any setting references are accidentally left behind once the definition is removed.
| from .signals import USER_RETIRE_LMS_CRITICAL, USER_RETIRE_LMS_MISC, USER_RETIRE_MAILINGS | ||
| from .utils import create_retirement_request_and_deactivate_account, username_suffix_generator | ||
|
|
||
| # This is a temporary import path while we transition from integrated_channels to channel_integrations |
There was a problem hiding this comment.
same reply as above.
|
|
||
| from ...models import UserOrgTag | ||
|
|
||
| # This is a temporary import path while we transition from integrated_channels to channel_integrations |
| from openedx.features.enterprise_support.tasks import clear_enterprise_customer_data_consent_share_cache | ||
| from openedx.features.enterprise_support.utils import clear_data_consent_share_cache, is_enterprise_learner | ||
|
|
||
| # This is a temporary import path while we transition from integrated_channels to channel_integrations |
|
another question: is there a formal DEPR for removing the old code from |
@deborahgu Feature flag is defined here for |
@deborahgu Could you guide me on what that process looks like? Also, since we are short on time and need to provide urgent support to a customer by merging this fix, would you recommend merging these changes into the forked repository for now? |
fix: fixed tests and quality failures
sameenfatima78
force-pushed
the
sameen/ENT-11127-fix
branch
from
7b98079 to
8e6e207
Compare
| setup_retirement_states | ||
| ) | ||
|
|
||
| # This is a temporary import path while we transition from integrated_channels to channel_integrations |
There was a problem hiding this comment.
Could you add this to the core settings file opened/envs/common.py and add a full toggle annotation? By keeping all of our settings in the central envs/ files, it helps us keep track of them and document them. And as Deborah mentioned pleased create an edx-platform GitHub issue and include a link to it in the .. toggle_tickets. You can declare the default as True there.
Furthermore, please access the setting directly (settings.ENABLE_LEGACY_INTEGRATED_CHANNELS) in all places instead of using getattr. This way, we will get a helpful exception if the setting name is misspelled or if any setting references are accidentally left behind once the definition is removed.
4 participants
As part of the initiative to make integrated_channels a separately installable plugin: https://github.com/openedx/enterprise-integrated-channels, we are temporarily making use of a feature flag to point to new data models. Once the changes are tested, we will roll out a change in openedx to remove the feature flag and entirely rely on new models that live within the channel_integrations app.