Fix: missing 'unit_code' argument in AsyncOEClient get_facility_data method#27
Open
emvollmer wants to merge 1 commit intoopennem:mainfrom
Open
Fix: missing 'unit_code' argument in AsyncOEClient get_facility_data method#27emvollmer wants to merge 1 commit intoopennem:mainfrom
emvollmer wants to merge 1 commit intoopennem:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I noticed the
AsyncOEClient.get_facility_dataclass method was missing theunit_codeargument. Was going to create an issue but realised it would be just as quick to fix it myself and create a PR :)Problem
Currently, the synchronous
OEClientsupports querying byunit_code, but the asynchronous implementation was missing this argument in its method signature, making it impossible to query specific units without hitting a 404 error when the unit code differs from the facility code.Solution
Added the
unit_codeargument toAsyncOEClient.get_facility_dataand updated the method where necessary to account for this change (i.e. made thefacility_codeoptional to allow for sole use ofunit_code). The changes align with the synchronous implementation.Type of change
Checklist