Skip to content

Fix: missing 'unit_code' argument in AsyncOEClient get_facility_data method #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emvollmer wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Fix: missing 'unit_code' argument in AsyncOEClient get_facility_data method #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions openelectricity/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,24 +530,26 @@ async def get_network_data(
async def get_facility_data(
self,
network_code: NetworkCode,
facility_code: str | list[str],
metrics: list[DataMetric],
facility_code: str | list[str] | None = None,
metrics: list[DataMetric] | None = None,
interval: DataInterval | None = None,
date_start: datetime | None = None,
date_end: datetime | None = None,
unit_code: str | list[str] | None = None,
) -> TimeSeriesResponse:
"""Get facility data for specified metrics."""
logger.debug(
"Getting facility data for %s/%s (metrics: %s, interval: %s)",
network_code,
facility_code,
facility_code or unit_code,
metrics,
interval,
)
await self._ensure_client()
params = {
"facility_code": facility_code,
"metrics": [m.value for m in metrics],
"unit_code": unit_code,
"metrics": [m.value for m in metrics] if metrics else None,
"interval": interval,
"date_start": date_start.isoformat() if date_start else None,
"date_end": date_end.isoformat() if date_end else None,
Expand Down