MCO-1805: MCO-1806: Add ManagedBootImagesCPMS feature gate & CPMS type to ManagedBootImages API #2396

djoshy · 2025-07-08T16:08:35Z

This PR adds:

A new feature gate for MCO-1007; whose goal is to support boot image updates to ControlPlaneMachineSets
A new MachineManagerMachineSetsResourceType enum for CPMS so they can be opted in for updates via the MachineConfiguration API object.

openshift-ci-robot · 2025-07-08T16:08:40Z

@djoshy: This pull request references MCO-1805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR adds:

A new feature gate for MCO-1007; whose goal is to support boot image updates to ControlPlaneMachineSets

A new MachineManagerMachineSetsResourceType enum for CPMS so they can be opted in for updates via the MachineConfiguration API object.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-07-08T16:09:01Z

Hello @djoshy! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

operator/v1/types_machineconfiguration.go

features/features.go

...sts/machineconfigurations.operator.openshift.io/ManagedBootImages+ManagedBootImagesCPMS.yaml

djoshy · 2025-09-18T18:18:26Z

With openshift/cluster-control-plane-machine-set-operator#368 merged, we should hopefully have all the prerequisites to proceed with this feature. I've rebased this PR to fix merge conflicts, and I have also added a new rule to only allow All or None for the ControlPlaneMachineSet resources.

operator/v1/types_machineconfiguration.go

features/features.go

operator/v1/types_machineconfiguration.go

...sts/machineconfigurations.operator.openshift.io/ManagedBootImages+ManagedBootImagesCPMS.yaml

operator/v1/types_machineconfiguration.go

djoshy · 2025-09-30T19:13:56Z

/retest

djoshy · 2025-10-01T18:09:28Z

/test remaining-required

openshift-ci · 2025-10-01T18:09:33Z

@djoshy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial-1of2

/test e2e-aws-serial-2of2

/test e2e-aws-serial-techpreview-1of2

/test e2e-aws-serial-techpreview-2of2

/test e2e-azure

/test e2e-gcp

/test e2e-upgrade

/test e2e-upgrade-out-of-change

/test images

/test integration

/test lint

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-crdify

/test verify-deps

/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build

pull-ci-openshift-api-master-images

pull-ci-openshift-api-master-integration

pull-ci-openshift-api-master-lint

pull-ci-openshift-api-master-minor-e2e-upgrade-minor

pull-ci-openshift-api-master-minor-images

pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-api-master-okd-scos-images

pull-ci-openshift-api-master-unit

pull-ci-openshift-api-master-verify

pull-ci-openshift-api-master-verify-client-go

pull-ci-openshift-api-master-verify-crd-schema

pull-ci-openshift-api-master-verify-crdify

pull-ci-openshift-api-master-verify-deps

pull-ci-openshift-api-master-verify-feature-promotion

Details

In response to this:

/test remaining-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed

/lgtm

openshift-ci-robot · 2025-10-07T11:47:24Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

openshift-ci · 2025-10-07T11:47:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

djoshy · 2025-10-07T13:18:01Z

/verified later

We'll verify this through openshift/machine-config-operator#5332, which updates the MCO to consume this API.

openshift-ci-robot · 2025-10-07T13:18:12Z

@djoshy: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later

We'll verify this through openshift/machine-config-operator#5332, which updates the MCO to consume this API.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

djoshy · 2025-10-07T13:20:29Z

/verified later @ptalgulk01

openshift-ci-robot · 2025-10-07T13:20:43Z

@djoshy: This PR has been marked to be verified later by @ptalgulk01.

Details

In response to this:

/verified later @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-07T14:12:40Z

/retest-required

Remaining retests: 0 against base HEAD 230d0e0 and 2 for PR HEAD 75a1397 in total

djoshy · 2025-10-07T16:33:13Z

/retest-required

deepsm007 · 2025-10-07T21:35:29Z

/test e2e-azure

djoshy · 2025-10-08T09:30:00Z

/retest-required

djoshy · 2025-10-08T13:35:30Z

/retest-required

openshift-ci-robot · 2025-10-08T19:10:15Z

/retest-required

Remaining retests: 0 against base HEAD 3a4cc53 and 1 for PR HEAD 75a1397 in total

openshift-ci · 2025-10-08T22:15:30Z

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`75a1397`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-10-09T01:10:10Z

/retest-required

Remaining retests: 0 against base HEAD c9bef43 and 0 for PR HEAD 75a1397 in total

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2025

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2025

openshift-ci bot requested review from JoelSpeed and everettraven July 8, 2025 16:11

djoshy commented Jul 8, 2025

View reviewed changes

operator/v1/types_machineconfiguration.go Show resolved Hide resolved

djoshy force-pushed the add-cpms-boot-image-updates branch from 18ab992 to 41adfe1 Compare July 8, 2025 21:21

openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2025

JoelSpeed reviewed Jul 9, 2025

View reviewed changes

djoshy force-pushed the add-cpms-boot-image-updates branch from 41adfe1 to 870a065 Compare September 18, 2025 18:15

djoshy commented Sep 18, 2025

View reviewed changes

operator/v1/types_machineconfiguration.go Outdated Show resolved Hide resolved

JoelSpeed reviewed Sep 19, 2025

View reviewed changes

djoshy force-pushed the add-cpms-boot-image-updates branch from 870a065 to 93e2839 Compare September 19, 2025 18:41

JoelSpeed reviewed Sep 23, 2025

View reviewed changes

operator/v1/types_machineconfiguration.go Outdated Show resolved Hide resolved

JoelSpeed reviewed Sep 24, 2025

View reviewed changes

operator/v1/types_machineconfiguration.go Outdated Show resolved Hide resolved

djoshy force-pushed the add-cpms-boot-image-updates branch 3 times, most recently from 23f9a62 to e484a4c Compare September 30, 2025 19:06

djoshy added 3 commits September 30, 2025 15:06

add CPMS boot image feature gate

6e37ab0

add CPMS type to MachineConfiguration API

8360db8

make update

75a1397

djoshy force-pushed the add-cpms-boot-image-updates branch from e484a4c to 75a1397 Compare September 30, 2025 19:06

This was referenced Oct 2, 2025

MCO-1895: add CPMS boot image update support openshift/enhancements#1818

Merged

MCO-1807: Add CPMS support in the MCO's boot image controller openshift/machine-config-operator#5332

Merged

JoelSpeed reviewed Oct 7, 2025

View reviewed changes

openshift-ci bot assigned JoelSpeed Oct 7, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 7, 2025

openshift-merge-bot bot merged commit 58cae3d into openshift:master Oct 9, 2025
27 of 28 checks passed

djoshy deleted the add-cpms-boot-image-updates branch October 9, 2025 17:53

djoshy restored the add-cpms-boot-image-updates branch October 9, 2025 17:53

MCO-1805: MCO-1806: Add ManagedBootImagesCPMS feature gate & CPMS type to ManagedBootImages API #2396

MCO-1805: MCO-1806: Add ManagedBootImagesCPMS feature gate & CPMS type to ManagedBootImages API #2396

Uh oh!

Conversation

djoshy commented Jul 8, 2025

Uh oh!

openshift-ci-robot commented Jul 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djoshy commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djoshy commented Sep 30, 2025

Uh oh!

djoshy commented Oct 1, 2025

Uh oh!

openshift-ci bot commented Oct 1, 2025

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 7, 2025

Uh oh!

openshift-ci bot commented Oct 7, 2025

Uh oh!

djoshy commented Oct 7, 2025

Uh oh!

openshift-ci-robot commented Oct 7, 2025

Uh oh!

djoshy commented Oct 7, 2025

Uh oh!

openshift-ci-robot commented Oct 7, 2025

Uh oh!

openshift-ci-robot commented Oct 7, 2025

Uh oh!

djoshy commented Oct 7, 2025

Uh oh!

deepsm007 commented Oct 7, 2025

Uh oh!

djoshy commented Oct 8, 2025

Uh oh!

djoshy commented Oct 8, 2025

Uh oh!

openshift-ci-robot commented Oct 8, 2025

Uh oh!

openshift-ci bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Jul 8, 2025 •

edited by openshift-ci bot

Loading

djoshy commented Sep 18, 2025 •

edited

Loading

openshift-ci bot commented Oct 8, 2025 •

edited

Loading