Skip to content

NO-JIRA: Sync kueue submodule to latest main#2064

Merged
kannon92 merged 1 commit into
openshift:mainfrom
PannagaRao:sync-submodule-main
Jun 25, 2026
Merged

NO-JIRA: Sync kueue submodule to latest main#2064
kannon92 merged 1 commit into
openshift:mainfrom
PannagaRao:sync-submodule-main

Conversation

@PannagaRao

@PannagaRao PannagaRao commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates upstream/kueue/src from 01e57625 to 50f6b7f1c.

Notable changes:

  • E2E tests for Partitionable Devices (#11420)
  • Increase code coverage for DRA errors (#12330)
  • Changes for Graduation of TASMultiLayerTopology to Beta (#12290)
  • Add accessProviders to MultiKueue ClusterProfiles (#12011)
  • Add preemptionGates support to ConcurrentAdmission (#11872)
  • Bump LWS to v0.9.0 (#12327)
  • Drop the deprecated DynamicResourceAllocation feature gate (#12258)
  • Fix webhook server silently dropping TLS parse errors (#12293)
  • Add kueue_pod_scheduling_gate_removal_seconds metric (#12137)
  • Add flavor assigner diagnostic reasons for NoFit results (#12378)

Full diff: kubernetes-sigs/kueue@01e5762...50f6b7f

Summary by CodeRabbit

  • Chores
    • Updated the upstream subproject reference to the latest revision.

@openshift-ci-robot

Copy link
Copy Markdown

@PannagaRao: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Updates upstream/kueue/src from 01e57625 to 50f6b7f1c.

Notable changes:

  • E2E tests for Partitionable Devices (#11420)
  • Increase code coverage for DRA errors (#12330)
  • Changes for Graduation of TASMultiLayerTopology to Beta (#12290)
  • Add accessProviders to MultiKueue ClusterProfiles (#12011)
  • Add preemptionGates support to ConcurrentAdmission (#11872)
  • Bump LWS to v0.9.0 (#12327)
  • Drop the deprecated DynamicResourceAllocation feature gate (#12258)
  • Fix webhook server silently dropping TLS parse errors (#12293)
  • Add kueue_pod_scheduling_gate_removal_seconds metric (#12137)
  • Add flavor assigner diagnostic reasons for NoFit results (#12378)

Full diff: kubernetes-sigs/kueue@01e5762...50f6b7f

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e469d1ea-4f0b-49cd-b742-1fb6e0aa7563

📥 Commits

Reviewing files that changed from the base of the PR and between ac46470 and ba06149.

📒 Files selected for processing (1)
  • upstream/kueue/src
🚧 Files skipped from review as they are similar to previous changes (1)
  • upstream/kueue/src

Walkthrough

The upstream/kueue/src git submodule reference is updated from commit 01e576255b55275520ff4ab0ebfdfa443ae7bcc2 to 50f6b7f1c3376f81109eb1d01841682255eef495. No other files are modified.

Changes

Submodule Pointer Update

Layer / File(s) Summary
upstream/kueue/src submodule bump
upstream/kueue/src
Submodule pointer advanced to a new upstream commit hash.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

lgtm

Suggested reviewers

  • sohankunkerkar

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error pkg/operator/target_config_reconciler.go logs the full Deployment object on error, which can include image refs and other spec fields with internal hostnames. Log only namespace/name and a terse error; avoid dumping the full Deployment/spec or any fields derived from env/image refs.
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning New e2e tests use util.GetAgnHostImage(), which falls back to registry.k8s.io/e2e-test-images/agnhost:2.66.0, so they can pull from a public registry. Set E2E_TEST_AGNHOST_IMAGE to a mirrored/internal image (or switch to an internal source) and verify on the IPv6 disconnected CI job.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: syncing the kueue submodule to the latest main commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Scanned all changed Ginkgo titles in the upstream patch; none used generated values, timestamps, UUIDs, or other run-specific data.
Test Structure And Quality ✅ Passed Reviewed the changed Ginkgo tests (managejobswithoutqueue, DRA whole-device/counter); they use scoped setup/cleanup, bounded waits, and focused Its. No quality issues found.
Microshift Test Compatibility ✅ Passed Reviewed the changed e2e tests (DRA, MultiKueue, TAS, LWS) and found no OpenShift-only APIs, MicroShift skips, or disallowed namespaces/features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Added e2e tests are single-node safe: no multi-node scheduling/HA assumptions and no missing SNO guards in the changed test files.
Topology-Aware Scheduling Compatibility ✅ Passed Only the submodule pointer changed; diff shows no added pod anti-affinity, topology spread, node selectors, or control-plane targeting.
Ote Binary Stdout Contract ✅ Passed Diff shows only one cmd/main change logs via setupLog.Error, and searches found no fmt.Print/Stdout/log.SetOutput violations in process-level code.
No-Weak-Crypto ✅ Passed The PR only updates the kueue submodule gitlink; no touched files add MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed PR is only a submodule sync; exact manifest search found no privileged:true, hostPID/Network/IPC:true, or allowPrivilegeEscalation:true settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PannagaRao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@kannon92

Copy link
Copy Markdown
Contributor

/hold

Looks like the test failures are legit issues.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2026
@PannagaRao

Copy link
Copy Markdown
Contributor Author

/hold

Looks like the test failures are legit issues.

Yes, Partitionable Devices Test are expected to fail as the cluster doesn't have the flag yet

@kannon92

Copy link
Copy Markdown
Contributor

Yes, Partitionable Devices Test are expected to fail as the cluster doesn't have the flag yet

Should we skip the upstream ones then? We can't merge this with failing tests. I guess for 4-18-4.21, PD should fail or skip.

@PannagaRao

PannagaRao commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Yes, Partitionable Devices Test are expected to fail as the cluster doesn't have the flag yet

Should we skip the upstream ones then? We can't merge this with failing tests. I guess for 4-18-4.21, PD should fail or skip.

We don't have to skip. Let me raise a PR in the release repo to add the k8s feature gate to the cluster. We can merge that first and then this?

@kannon92

kannon92 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

We don't have to skip. Let me raise a PR in the release repo to add the k8s feature gate to the cluster. We can merge that first and then this?

The feature gate doesn't exist for 4.18 or 4.19.

@PannagaRao

Copy link
Copy Markdown
Contributor Author

We don't have to skip. Let me raise a PR in the release repo to add the k8s feature gate to the cluster. We can merge that first and then this?

The feature gate doesn't exist for 4.18 or 4.19.

We are running DRA related upstream tests in 4.21+ CI jobs only.

@PannagaRao

Copy link
Copy Markdown
Contributor Author

/test test-e2e-ci-build-upstream-4-21

@PannagaRao

Copy link
Copy Markdown
Contributor Author

/test

@PannagaRao

Copy link
Copy Markdown
Contributor Author

/test test-e2e-ci-build-upstream-dra-4-21

@PannagaRao PannagaRao force-pushed the sync-submodule-main branch from 97d15e3 to 3333c3e Compare June 25, 2026 18:23
@PannagaRao

Copy link
Copy Markdown
Contributor Author

I have verified the upstream DRA e2e tests locally on a 4.22 OCP cluster (K8s 1.36) with both DRAExtendedResource and DRAPartitionableDevices feature gates enabled via CustomNoUpgrade.

ResourceSlices are published in split format (2 slices per node):

Pool slice (00000-) — sharedCounters only:

devices: null
sharedCounters:
- name: gpu-0-counters
  counters:
    compute: { value: "100" }
    memory: { value: 80Gi }

Device slice (00001-) — 40 devices ( 4 partitions + 1 full per GPU):

  devices:
  - name: gpu-0-partition-0
    attributes:
      partition: { int: 0 }
      partitionable: { bool: true }
    capacity:
      memory: { value: 20Gi }
    consumesCounters:
    - counterSet: gpu-0-counters
      counters:
        compute: { value: "25" }
        memory: { value: "20Gi" }
  - name: gpu-0-full
    attributes:
      partitionable: { bool: true }
    capacity:
      memory: { value: 80Gi }

Test Results

GOTOOLCHAIN=auto E2E_TARGET_FOLDERS="dra/whole-device dra/counter" make e2e-upstream-test

=== Running upstream e2e tests for: dra/whole-device ===
Running Suite: End To End DRA Integration Suite:  - /home/pbhojara/Documents/git-repo/kueue-operator/upstream/kueue/src/test/e2e/dra/whole-device
==============================================================================================
Will run 13 of 13 specs
------------------------------
Ran 13 of 13 Specs in 100.874 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
Running Suite: End To End DRA Partitionable Devices Suite:  - /home/pbhojara/Documents/git-repo/kueue-operator/upstream/kueue/src/test/e2e/dra/counter
==============================================================================================
Will run 8 of 8 specs
------------------------------
Ran 8 of 8 Specs in 69.464 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

@sohankunkerkar @kannon92 Using the above results can we merge the following PRs? Thanks!
PR 1. #2069
PR 2. This PR (currently includes PR 1 as second commit)

@PannagaRao

Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2026
@kannon92

Copy link
Copy Markdown
Contributor

Yea I'm happy to merge.

Updates upstream/kueue/src from 01e57625 to 50f6b7f1c.

Notable changes:
- E2E tests for Partitionable Devices (#11420)
- Increase code coverage for DRA errors (#12330)
- Changes for Graduation of TASMultiLayerTopology to Beta (#12290)
- Add accessProviders to MultiKueue ClusterProfiles (#12011)
- Add preemptionGates support to ConcurrentAdmission (#11872)
- Bump LWS to v0.9.0 (#12327)
- Drop the deprecated DynamicResourceAllocation feature gate (#12258)
- Fix webhook server silently dropping TLS parse errors (#12293)
- Add kueue_pod_scheduling_gate_removal_seconds metric (#12137)
- Add flavor assigner diagnostic reasons for NoFit results (#12378)

Signed-off-by: Pannaga Rao Bhoja Ramamanohara
@PannagaRao PannagaRao force-pushed the sync-submodule-main branch from 3333c3e to ba06149 Compare June 25, 2026 21:15
@PannagaRao

Copy link
Copy Markdown
Contributor Author

Yea I'm happy to merge.

PR is ready.

@kannon92

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2026
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

@PannagaRao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-ci-build-upstream-dra-4-21 97d15e3 link false /test test-e2e-ci-build-upstream-dra-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kannon92 kannon92 merged commit 989c83e into openshift:main Jun 25, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants