NO-JIRA: Sync kueue submodule to latest main#2064
Conversation
|
@PannagaRao: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe ChangesSubmodule Pointer Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PannagaRao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Looks like the test failures are legit issues. |
Yes, Partitionable Devices Test are expected to fail as the cluster doesn't have the flag yet |
Should we skip the upstream ones then? We can't merge this with failing tests. I guess for 4-18-4.21, PD should fail or skip. |
We don't have to skip. Let me raise a PR in the release repo to add the k8s feature gate to the cluster. We can merge that first and then this? |
The feature gate doesn't exist for 4.18 or 4.19. |
We are running DRA related upstream tests in 4.21+ CI jobs only. |
|
/test test-e2e-ci-build-upstream-4-21 |
|
/test |
|
/test test-e2e-ci-build-upstream-dra-4-21 |
97d15e3 to
3333c3e
Compare
|
I have verified the upstream DRA e2e tests locally on a 4.22 OCP cluster (K8s 1.36) with both ResourceSlices are published in split format (2 slices per node): Pool slice ( devices: null
sharedCounters:
- name: gpu-0-counters
counters:
compute: { value: "100" }
memory: { value: 80Gi }Device slice (00001-) — 40 devices ( 4 partitions + 1 full per GPU): Test Results
@sohankunkerkar @kannon92 Using the above results can we merge the following PRs? Thanks! |
|
/hold cancel |
|
Yea I'm happy to merge. |
Updates upstream/kueue/src from 01e57625 to 50f6b7f1c. Notable changes: - E2E tests for Partitionable Devices (#11420) - Increase code coverage for DRA errors (#12330) - Changes for Graduation of TASMultiLayerTopology to Beta (#12290) - Add accessProviders to MultiKueue ClusterProfiles (#12011) - Add preemptionGates support to ConcurrentAdmission (#11872) - Bump LWS to v0.9.0 (#12327) - Drop the deprecated DynamicResourceAllocation feature gate (#12258) - Fix webhook server silently dropping TLS parse errors (#12293) - Add kueue_pod_scheduling_gate_removal_seconds metric (#12137) - Add flavor assigner diagnostic reasons for NoFit results (#12378) Signed-off-by: Pannaga Rao Bhoja Ramamanohara
3333c3e to
ba06149
Compare
PR is ready. |
|
/lgtm |
|
@PannagaRao: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Updates
upstream/kueue/srcfrom01e57625to50f6b7f1c.Notable changes:
DynamicResourceAllocationfeature gate (#12258)kueue_pod_scheduling_gate_removal_secondsmetric (#12137)Full diff: kubernetes-sigs/kueue@01e5762...50f6b7f
Summary by CodeRabbit