Add counter sources to default Kueue CR for upstream PD e2e tests

[PannagaRao]

Summary

• Adds gpu.memory deviceClassMapping with counter sources to the default Kueue CR used by upstream e2e tests

Submodule sync PR #2064 depends on this

Summary by CodeRabbit

• Tests
  • Expanded end-to-end test coverage with a new counter-based device mapping scenario (dra/counter) to validate GPU memory behavior.
  • Improved test configuration to apply and reconcile the updated device-to-class mapping, then restore the original mappings after the run.
  • Updated per-folder end-to-end test report naming to use a sanitized folder-based name for clearer, consistent output.

[openshift-ci-robot]

@PannagaRao: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• Adds gpu.memory deviceClassMapping with counter sources to the default Kueue CR used by upstream e2e tests
• Enables upstream dra/counter (partitionable devices) e2e tests to run on OCP CI alongside existing dra/whole-device tests
• The operator auto-enables KueueDRAIntegrationPartitionableDevices when sources are configured and the K8s DRAPartitionableDevices gate is present

Depends on submodule sync PR #2064

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6775acb7-a492-4d7f-b524-e0101514819e

📥 Commits

Reviewing files that changed from the base of the PR and between 2916c2c and bccd345.

📒 Files selected for processing (1)

• upstream/kueue/e2e-test-ocp.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• upstream/kueue/e2e-test-ocp.sh

---

Walkthrough

The E2E script upstream/kueue/e2e-test-ocp.sh adds dra/counter setup and restore handling for Kueue cluster deviceClassMappings, and changes per-folder JUnit/JSON report filenames to use a sanitized folder-derived name.

Changes

E2E script updates

Layer / File(s)	Summary
DRA counter config and restore upstream/kueue/e2e-test-ocp.sh	Adds dra/counter to configure_kueue_for_folder and restore_kueue_for_folder, patching the cluster Kueue CR to switch resources.deviceClassMappings between counter-based gpu.memory settings and the restored gpu/gpu-late-dc mappings.
Sanitized report filenames upstream/kueue/e2e-test-ocp.sh	Uses report_name with / replaced by - when building the per-folder --junit-report and --json-report paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• openshift/kueue-operator#1990: Introduces closely related counter-based DRA deviceClassMappings behavior and restore handling that this script update configures for E2E coverage.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding counter sources to the default Kueue CR for upstream e2e tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were changed; the PR only adds static folder cases and sanitized report filenames.
Test Structure And Quality	✅ Passed	PASS: The PR only changes upstream/kueue/e2e-test-ocp.sh, a shell harness; no Ginkgo It/BeforeEach/Eventually code was modified, so the checklist isn’t applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo test body or MicroShift-unsupported OpenShift API usage was added; dra/counter only patches the Kueue CR and report names.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo specs were added; the changed OCP harness only enables existing DRA quota tests, and those bodies show no multi-node or HA assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	Only e2e test script/config changes were made; no deployment, operator, or controller scheduling logic was introduced.
Ote Binary Stdout Contract	✅ Passed	PASS: Changes are confined to e2e-test-ocp.sh; no OTE binary main/TestMain/RunSpecs stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only updates the OCP e2e wrapper; no new Ginkgo test bodies or network/IP assumptions were added, so this check is not triggered.
No-Weak-Crypto	✅ Passed	The changed script only patches Kueue config and report names; it contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom secret comparisons.
Container-Privileges	✅ Passed	No added manifest fields use privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation; the only match is an SCC grant in the script, not a pod spec.
No-Sensitive-Data-In-Logs	✅ Passed	New log messages are generic; the hostname strings only appear in config patches, and report_name changes affect filenames, not logs.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[kannon92]

/hold

Discussing this offline and this would be problematic.

the Counter isn't a valid API for older OCP versions and this would be deployed for all versions that Kueue is on.

[kannon92]

/test

[sohankunkerkar]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PannagaRao, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [PannagaRao,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sohankunkerkar]

/hold cancel

[kannon92]

/hold cancel

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 1b9c906 and 2 for PR HEAD cdedd90 in total

[PannagaRao]

/test test-e2e-ci-build-upstream-4-21

[PannagaRao]

/test test-e2e-ci-build-upstream-4-21

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 7be950a and 1 for PR HEAD cdedd90 in total

[kannon92]

/lgtm

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 7be950a and 2 for PR HEAD 2916c2c in total

[PannagaRao]

/hold

[PannagaRao]

/hold cancel

[kannon92]

/lgtm

[openshift-ci]

@PannagaRao: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kannon92]

/cherry-pick release-1.4

[openshift-cherrypick-robot]

@kannon92: new pull request created: #2086

Details

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.