Add NHC weekly periodic job to medik8s system-tests

[ugreener]

Summary

Add weekly periodic Prow job for NHC (Node Health Check) E2E tests to the medik8s system-tests 4.22-konflux CI configuration, matching the existing FAR/SBR/SNR periodic job pattern.

Changes

• Add e2e-nhc-weekly-aws periodic test lane to medik8s-system-tests-main__4.22-konflux.yaml
• Scheduled Sundays at 2 PM UTC (cron: 0 14 * * 0)
• Uses existing medik8s-catalogsource + medik8s-operator-subscribe step-registry refs
• Runs make run-tests with ECO_TEST_FEATURES=nhc-operator
• AWS cluster with default m5.xlarge instances (no ODF needed)
• Auto-generated periodics YAML included via make jobs

Job name

periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

Schedule

Job	Cron	Time (UTC)
FAR	0 4 * * 0	Sunday 4 AM
SBR	0 6 * * 0	Sunday 6 AM
SNR	0 8 * * 0	Sunday 8 AM
NHC	0 14 * * 0	Sunday 2 PM

Reference

• FAR periodic: e2e-far-weekly-aws (same file)
• SBR periodic: e2e-sbr-weekly-aws-odf (same file)
• SNR periodic: e2e-snr-weekly-aws (same file)

Jira: RHWA-1141

Summary by CodeRabbit

Adds a new weekly Prow periodic job for the medik8s system-tests CI configuration to run NHC E2E coverage on AWS. The job is scheduled for Sunday at 14:00 UTC, uses the existing medik8s catalogsource/operator-subscribe flow, and runs make run-tests with ECO_TEST_FEATURES=nhc-operator against the 4.22 konflux lane. This expands OpenShift CI coverage for Node Health Check and aligns its schedule with the staggered weekly timing of the related medik8s periodic jobs.

[ugreener]

/pj-rehearse auto-ack

[coderabbitai]

Warning

Review limit reached

@ugreener, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 47 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 91ccf189-b24b-480c-b59e-e187e9176389

📥 Commits

Reviewing files that changed from the base of the PR and between 69ce6db and b363311.

📒 Files selected for processing (1)

• ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

Walkthrough

A new weekly scheduled CI test job e2e-nhc-weekly-aws is added to the medik8s system-tests 4.22 konflux configuration. It runs on the medik8s-aws cluster profile with nhc-operator/node-healthcheck-operator settings, executes make run-tests, and declares CPU/memory resource requests.

Changes

Weekly AWS e2e job for NHC operator

Layer / File(s)	Summary
New scheduled job definition ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml	Adds e2e-nhc-weekly-aws with medik8s-aws targeting, intranet capability, cron 0 14 * * 0, nhc-operator feature settings, node-healthcheck-operator, standard catalogsource/subscribe steps, make run-tests, and 100m CPU / 200Mi memory requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• openshift/release#80362: Also adds a new scheduled medik8s-aws test job in the same konflux configuration file.

Suggested labels

jira/valid-reference

Suggested reviewers

• clobrano
• razo7

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding a weekly NHC periodic job to medik8s system-tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only adds a CI periodic job YAML entry; no Ginkgo test titles were added or changed, and the new names are static job aliases.
Test Structure And Quality	✅ Passed	PR only adds a CI YAML periodic job; no Ginkgo test code or test logic was changed, so the test-structure check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only adds a periodic CI job YAML entry; no new Ginkgo test code or MicroShift-unsafe APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only adds a periodic CI job config; no new Ginkgo test definitions or topology-sensitive test code were introduced.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a CI periodic job was added; the YAML has no pod affinity, nodeSelector, spread, PDB, or topology logic.
Ote Binary Stdout Contract	✅ Passed	The PR only adds a CI config YAML job; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo test code was added; this PR only adds a periodic CI lane config that reuses existing system-tests steps.
No-Weak-Crypto	✅ Passed	Touched YAML only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons appear in the diff.
Container-Privileges	✅ Passed	The new NHC periodic job adds no privileged/root/network-namespace/securityContext flags; the generated job spec only shows standard ci-operator container settings.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The new NHC periodic job only adds CI config fields and reuses existing steps; no log/echo/debug statements or new secrets, tokens, or PII appear.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml`:
- Around line 279-304: The new periodic test `e2e-nhc-weekly-aws` has been added
to the CI configuration but the required ProwJob specifications have not been
generated. Run `make update` from the repository root to regenerate the
downstream artifacts in the ci-operator/jobs/ directory. This will generate the
expected ProwJob specification file containing the
`periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws` job
definition for the new test.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 46fa2282-cb1c-4165-9473-f04b248b4a1d

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1eb6b and 36571ee.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/medik8s/system-tests/medik8s-system-tests-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/medik8s/system-tests/medik8s-system-tests-main__4.22-konflux.yaml

[ugreener]

/pj-rehearse auto-ack

[openshift-merge-bot]

@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@ugreener: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws	44ee676	link	unknown	/pj-rehearse periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ugreener]

/pj-rehearse ack

[openshift-merge-bot]

@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[ugreener]

/override ci/rehearse/periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

[openshift-ci]

@ugreener: ugreener unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/rehearse/periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@ugreener: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-medik8s-system-tests-main-4.22-konflux-e2e-nhc-weekly-aws	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, ugreener

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/medik8s/system-tests/OWNERS [razo7,ugreener]
• ci-operator/jobs/medik8s/system-tests/OWNERS [razo7,ugreener]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[razo7]

/pj-rehearse ack

[openshift-merge-bot]

@razo7: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.