-
Notifications
You must be signed in to change notification settings - Fork 684
Remove human readable texts from GUI element identifiers #12394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
993df0e to
721392e
Compare
|
Could not remove all text/windowTitle references because some UI elements lack unique, stable identifiers (objectName/id). To remove human readable text from GUI elements objectName/id should be added. |
721392e to
f818559
Compare
|
Yes. We already agreed on that unique IDs shall be added. Need assistance with this? Thank you |
f818559 to
1288518
Compare
|
@DeepDiver1975 |
4240122 to
f66a1de
Compare
e599234 to
1a94dc7
Compare
1a94dc7 to
f20f6de
Compare
f20f6de to
d27ffbc
Compare
saw-jan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PrajwolAmatya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated the UI-level selectors to remove the human readable text from the GUI element identifier and don't make the element identifier depend on it.
Fixes: #12373