Skip to content

Conversation

@ishabaral
Copy link
Contributor

Updated the UI-level selectors to remove the human readable text from the GUI element identifier and don't make the element identifier depend on it.

Fixes: #12373

@ishabaral ishabaral self-assigned this Nov 5, 2025
@update-docs
Copy link

update-docs bot commented Nov 5, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch 3 times, most recently from 993df0e to 721392e Compare November 11, 2025 06:54
@ishabaral
Copy link
Contributor Author

Could not remove all text/windowTitle references because some UI elements lack unique, stable identifiers (objectName/id). To remove human readable text from GUI elements objectName/id should be added.
@DeepDiver1975

@ishabaral ishabaral marked this pull request as ready for review November 11, 2025 07:57
@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch from 721392e to f818559 Compare November 11, 2025 07:59
@DeepDiver1975
Copy link
Member

Yes. We already agreed on that unique IDs shall be added. Need assistance with this? Thank you

@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch from f818559 to 1288518 Compare November 11, 2025 11:35
@ishabaral
Copy link
Contributor Author

ishabaral commented Nov 11, 2025

@DeepDiver1975
Yes, you need to add an unique identifiers(name/id) on those selectors, where I've removed/commented the text prop.

@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch from 4240122 to f66a1de Compare November 14, 2025 11:22
@ishabaral ishabaral marked this pull request as draft November 14, 2025 11:22
@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch 4 times, most recently from e599234 to 1a94dc7 Compare November 18, 2025 06:37
@ishabaral ishabaral marked this pull request as ready for review November 18, 2025 07:01
@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch from 1a94dc7 to f20f6de Compare November 19, 2025 04:22
@ishabaral ishabaral requested a review from saw-jan November 19, 2025 04:22
@ishabaral ishabaral force-pushed the remove_human_readable_text_from_selectors branch from f20f6de to d27ffbc Compare November 19, 2025 04:58
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] Remove human readable texts from GUI element identifiers

5 participants