Repository navigation
[1.0] Fix CI for phpseclib 2.0's new tests and PHP 7.2 - #22
Open
jack-worman wants to merge 2 commits into
Open
jack-worman wants to merge 2 commits into
jack-worman wants to merge 2 commits into
Conversation
This was referenced Nov 2, 2026
jack-worman
marked this pull request as draft
November 2, 2026 19:59
jack-worman
force-pushed
the
Skip-tests-of-new-2.0-internals
branch
from
November 2, 2026 20:41
7a12e45 to
ba7d491
Compare
jack-worman
marked this pull request as ready for review
November 2, 2026 20:42
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two CI failures on 1.0:
X509::_fetchURL(), anSFTPsubclass that overrides_list()), so they fail here.update.phpnow skips them, and it also deletes the test files thatci.ymlused torm, so phpseclib's CI ([3.0] Test phpseclib2_compat in CI phpseclib#2265) can prepare the tests the same way.^5.7|^6.0|^9.4allows over security advisories, except 9.6.33+, which needs PHP 7.3, so the 7.2 jobs fail atcomposer install. This allows^8.5and runs the PHPUnit 9 conversion on 7.2 too, like phpseclib/phpseclib@81e21af8.