Skip to content

[1.0] Fix CI for phpseclib 2.0's new tests and PHP 7.2 - #22

Open
jack-worman wants to merge 2 commits into
phpseclib:1.0from
jack-worman:Skip-tests-of-new-2.0-internals
Open

jack-worman wants to merge 2 commits into
phpseclib:1.0from
jack-worman:Skip-tests-of-new-2.0-internals

Conversation

@jack-worman

@jack-worman jack-worman commented Nov 2, 2026 •

Copy link
Copy Markdown

Fixes two CI failures on 1.0:

  • phpseclib 2.0's new X509 URL-fetch tests and SFTP rawlist tests use 2.0 internals (X509::_fetchURL(), an SFTP subclass that overrides _list()), so they fail here. update.php now skips them, and it also deletes the test files that ci.yml used to rm, so phpseclib's CI ([3.0] Test phpseclib2_compat in CI phpseclib#2265) can prepare the tests the same way.
  • On PHP 7.2, Composer blocks every PHPUnit version that ^5.7|^6.0|^9.4 allows over security advisories, except 9.6.33+, which needs PHP 7.3, so the 7.2 jobs fail at composer install. This allows ^8.5 and runs the PHPUnit 9 conversion on 7.2 too, like phpseclib/phpseclib@81e21af8.

@jack-worman
jack-worman force-pushed the Skip-tests-of-new-2.0-internals branch from 7a12e45 to ba7d491 Compare November 2, 2026 20:41
@jack-worman
jack-worman marked this pull request as ready for review November 2, 2026 20:42
@jack-worman jack-worman changed the title [1.0] Skip the new 2.0 tests that use 2.0 internals [1.0] Fix CI for phpseclib 2.0's new tests and PHP 7.2 Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant