Skip to content

[1.0] Fix CI for phpseclib 2.0's new tests and PHP 7.2 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jack-worman wants to merge 2 commits into
base: 1.0
Choose a base branch
from
Open

[1.0] Fix CI for phpseclib 2.0's new tests and PHP 7.2 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba7d491
Skip-tests-of-new-2.0-internals
jack-worman Nov 2, 2026
0844efb
Fix-PHP-7.2-PHPUnit-install
jack-worman Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,11 @@ jobs:
run: |
git clone -b 2.0 --single-branch https://github.com/phpseclib/phpseclib.git temp
mv temp/tests tests
rm tests/Functional/Net/SCPSSH2UserStoryTest.php
rm tests/Unit/Net/SSH1Test.php
rm tests/Unit/Net/SSH2UnitTest.php
rm tests/Unit/Math/BigInteger/InternalTest.php
php .github/workflows/update.php
- name: Composer Install
run: composer install --no-interaction --no-cache
- name: Make Tests Compatiable With PHPUnit 9+
if: matrix.php-version != '5.6' && matrix.php-version != '7.0' && matrix.php-version != '7.1' && matrix.php-version != '7.2'
if: matrix.php-version != '5.6' && matrix.php-version != '7.0' && matrix.php-version != '7.1'
run: php tests/make_compatible_with_phpunit9.php
- name: Setup Secure Shell Functional Tests
if: matrix.os == 'ubuntu-latest'
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/update.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ function replaceFileContents($fileName, $search, $replace)
file_put_contents($fileName, $updatedFileContents);
}

unlink('tests/Functional/Net/SCPSSH2UserStoryTest.php');
unlink('tests/Unit/Net/SSH1Test.php');
unlink('tests/Unit/Net/SSH2UnitTest.php');
unlink('tests/Unit/Net/SFTPUnitTest.php');
unlink('tests/Unit/Math/BigInteger/InternalTest.php');

replaceFileContents('tests/PhpseclibTestCase.php', '~%s/../phpseclib/%s~', '%s/../src/%s');
replaceFileContents('tests/Unit/Crypt/RSA/LoadKeyTest.php', '~ public function testSetPrivate\(\)~', ' private function skiptestSetPrivate()');
replaceFileContents('tests/Unit/Crypt/RSA/ModeTest.php', '~ public function testOAEPWithLabel\(\)~', ' private function skiptestOAEPWithLabel()');
replaceFileContents('tests/Unit/Crypt/RSA/ModeTest.php', '~ public function testOAEPWithLabel\(\)~', ' private function skiptestOAEPWithLabel()');
replaceFileContents('tests/Unit/File/X509/X509Test.php', '~ public function test(URLFetch\w+)\(\)~', ' private function skiptest$1()');
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"phpseclib/phpseclib": "^3.0"
},
"require-dev": {
"phpunit/phpunit": "^5.7|^6.0|^9.4"
"phpunit/phpunit": "^5.7|^6.0|^8.5|^9.4"
},
"autoload": {
"psr-4": {"phpseclib\\": "src/"}
Expand Down
Loading