Drop redundant uint32_t narrowing at cap_grid_dim_x in repeat_arange/get_source_mask - #6063
Open
q10 wants to merge 1 commit into
Open
Drop redundant uint32_t narrowing at cap_grid_dim_x in repeat_arange/get_source_mask#6063q10 wants to merge 1 commit into
q10 wants to merge 1 commit into
Conversation
…get_source_mask Summary: cap_grid_dim_x takes int64_t; the static_cast<uint32_t>(batch_size) pre-narrowing is redundant. Drops it in repeat_arange and get_source_mask. Reviewed By: cthi Differential Revision: D112381247
Contributor
|
@q10 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112381247. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: cap_grid_dim_x takes int64_t; the static_cast<uint32_t>(batch_size) pre-narrowing is redundant. Drops it in repeat_arange and get_source_mask.
Reviewed By: cthi
Differential Revision: D112381247