Skip to content

Drop redundant uint32_t narrowing at cap_grid_dim_x in repeat_arange/get_source_mask #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q10 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop redundant uint32_t narrowing at cap_grid_dim_x in repeat_arange/get_source_mask #6063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions fbgemm_gpu/src/jagged_tensor_ops/get_source_mask.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,7 @@ Tensor get_source_mask_cuda(
// correctness-preserving.
// See: https://github.com/ROCm/hip/issues/2253
const auto num_blocks = utils::cuda::cap_grid_dim_x(
static_cast<uint32_t>(batch_size),
kMaxThreads,
at::cuda::getCurrentCUDAStream());
batch_size, kMaxThreads, at::cuda::getCurrentCUDAStream());

AT_DISPATCH_INDEX_TYPES(
num_sources.scalar_type(), "get_source_mask_kernel", ([&] {
Expand Down
4 changes: 1 addition & 3 deletions fbgemm_gpu/src/jagged_tensor_ops/repeat_arange.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,7 @@ Tensor repeat_arange_cuda(const Tensor& lengths) {
// correctness-preserving.
// See: https://github.com/ROCm/hip/issues/2253
const auto num_blocks = utils::cuda::cap_grid_dim_x(
static_cast<uint32_t>(batch_size),
kMaxThreads,
at::cuda::getCurrentCUDAStream());
batch_size, kMaxThreads, at::cuda::getCurrentCUDAStream());

AT_DISPATCH_INDEX_TYPES(
lengths.scalar_type(), "repeat_arange_kernel", ([&] {
Expand Down
Loading