Use prebuilt Hermes when building Android on CI#54707
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87929652. |
j-piasecki
force-pushed
the
export-D87929652
branch
2 times, most recently
from
6de5afd to
4c98379
Compare
j-piasecki
force-pushed
the
export-D87929652
branch
13 times, most recently
from
721c2f3 to
404cb20
Compare
cortinico
approved these changes
Dec 12, 2025
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
force-pushed
the
export-D87929652
branch
from
404cb20 to
3f25245
Compare
Summary: Changelog: [Internal] Reviewed By: cortinico Differential Revision: D87929652
j-piasecki
force-pushed
the
export-D87929652
branch
from
3f25245 to
94a852c
Compare
Collaborator
|
This pull request was successfully merged by @j-piasecki in 076e6a1 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 076e6a1. |
chrfalch
added a commit
that referenced
this pull request
Jan 27, 2026
…om-source PR #54707 removed `prefabPublishing = true` from hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed by `find_package(hermes-engine)` in ReactAndroid's native build. Adding `prefabPublishing = true` back restores the CMake config generation and proper Gradle task ordering. The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed.
meta-codesync Bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
…om-source (#55310) Summary: PR #54707 removed `prefabPublishing = true` from hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed by `find_package(hermes-engine)` in ReactAndroid's native build. Adding `prefabPublishing = true` back restores the CMake config generation and proper Gradle task ordering. The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed. ## Changelog: [ANDROID] [FIXED] - Re-added prefabPublishing=true to make Android build from source work again Pull Request resolved: #55310 Test Plan: - Build RN Tester and build from source, verify that Android builds correctly. - Check CI and verify that Hermes is not built from source Reviewed By: cipolleschi Differential Revision: D91581389 Pulled By: cortinico fbshipit-source-id: 01953cc071d22faa84920ebe30cc1426c8d420e4
alanleedev
pushed a commit
that referenced
this pull request
Jan 29, 2026
…om-source (#55310) Summary: PR #54707 removed `prefabPublishing = true` from hermes-engine when switching to prebuilt Hermes by default. This broke build-from-source because AGP no longer generates the CMake config file needed by `find_package(hermes-engine)` in ReactAndroid's native build. Adding `prefabPublishing = true` back restores the CMake config generation and proper Gradle task ordering. The same PR also disables all hermes tasks when not building from source - which will make the CI work correctly - ie. not build hermes from source when not needed. ## Changelog: [ANDROID] [FIXED] - Re-added prefabPublishing=true to make Android build from source work again Pull Request resolved: #55310 Test Plan: - Build RN Tester and build from source, verify that Android builds correctly. - Check CI and verify that Hermes is not built from source Reviewed By: cipolleschi Differential Revision: D91581389 Pulled By: cortinico fbshipit-source-id: 01953cc071d22faa84920ebe30cc1426c8d420e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D87929652