fix(collect): cluster resource errors json file has wrong name #1936
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - name: Reorganize artifacts | ||
| run: | | ||
| # Move artifacts from nested directories to test/output | ||
| find test/output/test-results-* -type f -exec mv {} test/output/ \; |
There was a problem hiding this comment.
Bug: Reorganize artifacts step fails without downloaded artifacts
The find test/output/test-results-* command fails when no artifacts match the pattern because bash expands the glob to a literal string that doesn't exist. This prevents the "Check for regressions" and "Generate summary report" steps from running when test jobs fail before uploading artifacts. Adding || true or using if: always() on subsequent steps would ensure proper failure reporting even when artifacts are missing.
| fi | ||
| if [ "${{ steps.compare-supportbundle.outcome }}" == "failure" ] && [ "${{ steps.compare-supportbundle.outputs.baseline_missing }}" != "true" ]; then | ||
| if [ "${{ needs.test-supportbundle.result }}" == "failure" ]; then |
There was a problem hiding this comment.
Bug: Skipped test jobs not detected as failures
The regression check only detects jobs with result failure but ignores jobs with result skipped. When the build-binaries job fails, test jobs are skipped, and the workflow incorrectly reports success instead of failure. The check should also count skipped jobs as failures to ensure the workflow fails when tests don't run.
| fi | ||
| if [ "${{ steps.compare-supportbundle.outcome }}" == "failure" ] && [ "${{ steps.compare-supportbundle.outputs.baseline_missing }}" != "true" ]; then | ||
| if [ "${{ needs.test-supportbundle.result }}" == "failure" ]; then |
There was a problem hiding this comment.
Bug: Baseline update step skipped after regression failures
The Update baselines step won't execute when regressions are detected because the preceding Check for regressions step exits with code 1, terminating the workflow. The step condition lacks always() to ensure execution regardless of prior step failures. This prevents users from updating baselines when regressions exist, which defeats the purpose of the manual baseline update feature.
emosbaugh
changed the title
Description, Motivation and Context
The cluster resources collector is writing replicaset resources to a directory called statefulsets-errors.json, instead of replicasets.
Fixes: #1916
Also fixes issues:
./scripts/update_baselines.sh"gh run download" command fails with "fatal not a git repository" error.Checklist
Does this PR introduce a breaking change?