Repository navigation
Make Diff<'repo> not be Send - #1342
Merged
Merged
Conversation
DanielEScherzer
force-pushed
the
diff-not-send
branch
from
November 14, 2026 17:11
b567d17 to
dd4ea0b
Compare
Contributor
Author
|
Hmm, error output was improved on beta, rust-lang/rust#161624 |
DanielEScherzer
force-pushed
the
diff-not-send
branch
from
November 14, 2026 17:22
dd4ea0b to
418820a
Compare
Contributor
Author
|
...but the lowest supported Rust version still has different error messages |
Contributor
Author
|
Nightly was failing, ran cargo bisect until it found rust-lang/rust@526c36b, differences caused by the new solver, reported at rust-lang/rust#160895 (rust-lang/rust#160895 (comment)) |
Doing so is unsound as `Repository` instances cannot be safely shared across threads. Since the error messages are different on different versions of Rust, update the GitHub actions setup to use the correct expected output based on the tested version. Fixes rust-lang#1333
DanielEScherzer
force-pushed
the
diff-not-send
branch
from
November 14, 2026 19:15
418820a to
a15ba04
Compare
Contributor
Author
|
@rustbot label +semver-breaking-change |
Collaborator
|
Error: The feature Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing so is unsound as
Repositoryinstances cannot be safely shared across threads.Since the error messages are different on different versions of Rust, update the GitHub actions setup to use the correct expected output based on the tested version.
Fixes #1333