Skip to content

Test EII UI tests with prefer-dynamic#156577

Open
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-default-dynamic
Open

Test EII UI tests with prefer-dynamic#156577
AsakuraMizu wants to merge 1 commit into
rust-lang:mainfrom
AsakuraMizu:eii-default-dynamic

Conversation

@AsakuraMizu
Copy link
Copy Markdown
Contributor

@AsakuraMizu AsakuraMizu commented May 14, 2026

View all comments

Tracking issue: #125418

Remove no-prefer-dynamic from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs.

Fixes #151271.

Tested with:

python3 x.py test tests/ui/eii --force-rerun

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

Copy link
Copy Markdown
Contributor

@mejrs mejrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 14, 2026

📌 Commit 8f221d1 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #155360 (map_try_insert changes)
 - #156493 (actually run the temp_dir doctest)
 - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`)
 - #156565 (delegation: emit error when self type is not specified and accessed)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 15, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #156493 (actually run the temp_dir doctest)
 - #156452 (Implement pinned drop sugar)
 - #156600 (Make const param default test reproduce original ICE)
 - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`)
 - #156565 (delegation: emit error when self type is not specified and accessed)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)
 - #156587 (Correctly handle associated items in rustdoc macro expansion)
@Zalathar
Copy link
Copy Markdown
Member

Zalathar commented May 15, 2026

Failed in rollup? #156605 (comment)

@bors r-

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

This pull request was unapproved.

This PR was contained in a rollup (#156605), which was unapproved.

View changes since this unapproval

@Zalathar
Copy link
Copy Markdown
Member

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
Test EII UI tests with prefer-dynamic


try-job: aarch64-apple
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

💔 Test for 6b93d07 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@AsakuraMizu
Copy link
Copy Markdown
Contributor Author

😮 Oh I didn't expect it to fail on macOS. I'll look into it.

@mejrs
Copy link
Copy Markdown
Contributor

mejrs commented May 15, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 15, 2026

📌 Commit 124126e has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Test EII UI tests with prefer-dynamic

Tracking issue: #125418

Remove `no-prefer-dynamic` from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs.

Fixes #151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 16, 2026

💔 Test for b042d67 failed: CI. Failed job:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#13 DONE 22.5s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.173 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.191 Executing: /tmp/apt-key-gpghome.7TJQOJbcI7/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 1.813 gpg: key 74DA7924C5513486: public key "Igor Kozhukhov <igor@dilos.org>" imported
#14 1.818 gpg: Total number processed: 1
#14 1.818 gpg:               imported: 1
#14 DONE 1.9s

@AsakuraMizu
Copy link
Copy Markdown
Contributor Author

This failure looks unrelated to this PR: it failed while building the Docker image (/tmp/build-x86_64-fortanix-unknown-sgx-toolchain.sh) before any tests ran.

@mejrs
Copy link
Copy Markdown
Contributor

mejrs commented May 16, 2026

Alright, let's try again

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 16, 2026

📌 Commit 124126e has been approved by mejrs

It is now in the queue for this repository.

A failed build status on this PR was cleared due to the approval.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Test EII UI tests with prefer-dynamic

Tracking issue: #125418

Remove `no-prefer-dynamic` from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs.

Fixes #151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 16, 2026

💔 Test for 4335cbf failed: CI. Failed job:

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
#13 DONE 23.8s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.162 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.180 Executing: /tmp/apt-key-gpghome.9VMAJOvbkA/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.942 gpg: key 74DA7924C5513486: public key "Igor Kozhukhov <igor@dilos.org>" imported
#14 0.946 gpg: Total number processed: 1
#14 0.946 gpg:               imported: 1
#14 DONE 1.0s

@AsakuraMizu
Copy link
Copy Markdown
Contributor Author

It seems other PRs are also stuck here. 😂

@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented May 16, 2026

@bors retry

Spurious failure fixed by #156640.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 16, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
rust-bors Bot pushed a commit that referenced this pull request May 16, 2026
Rollup of 6 pull requests

Successful merges:

 - #152852 (Remove driver_lint_caps)
 - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found)
 - #156518 ([style] rustfmt `match`es with comments in or-patterns)
 - #156596 (Split `LintExpectationId`s)
 - #156577 (Test EII UI tests with prefer-dynamic)
 - #156633 (Add regression test for issue #41261)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 17, 2026
…=mejrs

Test EII UI tests with prefer-dynamic

Tracking issue: rust-lang#125418

Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs.

Fixes rust-lang#151271.

Tested with:

```sh
python3 x.py test tests/ui/eii --force-rerun
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Externally Implementable Items: error: undefined symbol with dynamic linking

6 participants