fix 5GeV selection

[pinkenburg]

Types of changes

• [ X] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

cut and paste error for the pythia8 5 GeV jet selection (it stopped to work, no bad files were selected)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Motivation/Context

This PR fixes critical bugs in the CreateFileList.pl script that were preventing proper file selection for specific pythia8 jet production types. The script is responsible for identifying and cataloging production files in the sPHENIX file catalog database. Production type 36 corresponds to pythia8 Jet samples with ptmin = 5 GeV threshold.

Key Changes

• Production type 36 (pythia8 Jet ptmin = 5 GeV): Fixed incomplete if (defined $double) block. The original code was missing the body of the conditional—it lacked the $doubleok = 1 flag setting and the critical _pythia8_Detroit suffix appending logic, and also bypassed all pileup handling by immediately calling &commonfiletypes(). The corrected version now properly handles double-interaction overlay selection and pileup configuration.

• Production type 49 (pythia8 Jet ptmin = 80 GeV): Fixed elsif statement indentation/positioning within the main production-type dispatch if/elsif ladder to ensure the branch is correctly recognized during control flow.

Potential Risk Areas

• Reconstruction behavior: These fixes restore critical file selection logic. Production types 36 and 49 would have been non-functional with no files selected when requested, especially with the --double flag for Detroit overlay simulations. Users running analyses on 5 GeV and 80 GeV jet samples may need to re-run file list generation.
• File catalog dependencies: The script relies on correct database query results; any malformed production names would cascade through downstream file identification.

Possible Future Improvements

• Add validation/testing of production type file selection to catch similar cut-and-paste errors
• Consider refactoring the long if/elsif chain into a data-driven structure (e.g., hash-based configuration) to reduce maintenance burden

Note: AI-assisted analysis was used in this summary. Please verify the technical details against the actual code review.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8a5799a-e771-46fa-ae01-58e95e53e2c7

📥 Commits

Reviewing files that changed from the base of the PR and between a25ae02 and 540af5e.

📒 Files selected for processing (1)

• offline/framework/frog/CreateFileList.pl

---

📝 Walkthrough

Walkthrough

The pull request fixes production-type dispatch logic in the file list creation script. Specifically, it adds a conditional guard to prevent appending the _pythia8_Detroit suffix when double-interaction mode is not active for prodtype 36, and corrects the elsif indentation for prodtype 49 to ensure proper branch recognition.

Changes

Cohort / File(s)	Summary
Production-type dispatch guards offline/framework/frog/CreateFileList.pl	Fixed prodtype 36 to conditionally append _pythia8_Detroit suffix only when $double is defined; corrected indentation of prodtype 49 elsif branch for proper control flow recognition.

Possibly related PRs

• add double interaction for pythia8 5GeV jets #4255: Directly modifies the same prodtype 36 branch and _pythia8_Detroit suffix logic with conflicting approach (makes suffix unconditional rather than conditional on $double).
• add 8,80GeV pythia8 jets and update double interactions #4249: Overlaps on the same prodtype 36 and 49 handling sections within CreateFileList.pl's dispatch logic.
• exclude double pythia8 in filename if not chosen double #4236: Implements similar guard logic for _pythia8_Detroit filename selection tied to the $double variable state.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}