add type 51: ets meson pt > 8GeV

[pinkenburg]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• [X ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work for users)
• Requiring change in macros repository (Please provide links to the macros pull request in the last section)
• I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This PR adds the pythia8 Detroit with eta meson pt >= 8GeV sample as type 51, no jenkins testing: [skip-ci]

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Motivation

This PR adds support for a new physics production type to the sPHENIX simulation framework: pythia8-generated events with eta meson particles having transverse momentum ≥ 8 GeV. This complements the existing type 50 (eta ptmin = 3 GeV) and enables higher-pT eta meson studies.

Key Changes

• Added production type 51 to CreateFileList.pl:
  • Registered as "JS pythia8 Detroit eta ptmin = 8 GeV" in the production description hash
  • Base filename set to pythia8_Eta8 for file cataloging
  • Supports pileup configuration with multiple embedding options (p+Au, Au+Au central, O+O collisions)
  • Follows established pattern used by type 50 (eta ptmin = 3 GeV)

Risk Assessment

• Low risk: This is a straightforward addition of a new enumeration value following proven code patterns
• No IO format changes: Uses standard naming convention and file type handling
• No reconstruction behavior changes: Purely adds a new production type selection without altering analysis logic
• No thread-safety issues: Perl script executes sequentially for file list generation
• Minimal performance impact: Only affects file catalog lookups when type 51 is explicitly requested

Notes

AI-assisted analysis: Please review the actual physics parameters (eta ptmin = 8 GeV threshold, Detroit sample configuration) and verify they match intended physics goals. Confirm the filename conventions align with your collaboration's data organization standards.

[coderabbitai]

📝 Walkthrough

Walkthrough

CreateFileList.pl adds support for production type 51 ("pythia8 eta ptmin = 8 GeV"). A new descriptor entry is registered, and a corresponding production-type branch handles filename construction with conditional pileup and embed-specific hijing background suffixes.

Changes

Production Type 51 Support

Layer / File(s)	Summary
Production Type Descriptor offline/framework/frog/CreateFileList.pl	Production type 51 is registered in %proddesc with description "pythia8 eta ptmin = 8 GeV".
Production Type Handler offline/framework/frog/CreateFileList.pl	A new elsif ($prodtype == 51) branch constructs base filename pythia8_Eta8, conditionally applies pileup suffix (unless -nopileup is set), applies -embed-specific hijing background suffixes, sets $pileupstring, and calls &commonfiletypes().

Possibly related PRs

• sPHENIX-Collaboration/coresoftware#4261: Adds pythia8 "eta" production type 50 with similar descriptor and handler structure.
• sPHENIX-Collaboration/coresoftware#4257: Modifies production-type dispatch branches in the same CreateFileList.pl file.
• sPHENIX-Collaboration/coresoftware#4107: Adds a new production type with %proddesc entry and corresponding elsif branch calling commonfiletypes().

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9c130a4-e894-4e6f-89e3-9210ecdc02f1

📥 Commits

Reviewing files that changed from the base of the PR and between 988dbf9 and fc63948.

📒 Files selected for processing (1)

• offline/framework/frog/CreateFileList.pl

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if files for types 50 and 51 contain "Detroit" in their names
rg -n "pythia8_Eta3|pythia8_Eta8" --type perl -A2 -B2

Repository: sPHENIX-Collaboration/coresoftware

Length of output: 725

---

Descriptions mismatch filenames for production types 50 and 51.

Lines 91–92 describe these as "JS pythia8 Detroit eta ptmin = 3/8 GeV", but the implementations set filenames to pythia8_Eta3 and pythia8_Eta8 without "Detroit". Verify whether:

• The descriptions should remove "Detroit", or
• The filenames should include "Detroit" (as they do for type 26 and conditionally for types 11, 19, 21)

Align descriptions with actual production file naming in your catalog.

[pinkenburg]

This is on purpose - the main feature of those files is the filter on the eta mesons with pt >3 or >8 GeV

[coderabbitai]

@pinkenburg, understood — "Detroit" in the description identifies the underlying pythia8 Detroit sample, while the filename (pythia8_Eta3 / pythia8_Eta8) highlights the defining physics filter (eta meson pT threshold). The naming is intentional and consistent with the production convention. Thanks for the clarification!

---

✏️ Learnings added

Learnt from: pinkenburg
Repo: sPHENIX-Collaboration/coresoftware PR: 4265
File: offline/framework/frog/CreateFileList.pl:91-92
Timestamp: 2026-05-09T20:29:05.511Z
Learning: In `offline/framework/frog/CreateFileList.pl` (sPHENIX coresoftware), production types 50 and 51 intentionally use descriptions that include "Detroit" (e.g., "JS pythia8 Detroit eta ptmin = 3 GeV" / "8 GeV") while their filenames are `pythia8_Eta3` and `pythia8_Eta8` without "Detroit". "Detroit" identifies the underlying pythia8 Detroit sample; the filename focuses on the defining eta meson pT filter. This discrepancy is by design and should not be flagged.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.