Skip to content

add type 51: ets meson pt > 8GeV #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pinkenburg merged 1 commit into from
May 9, 2026
Merged

add type 51: ets meson pt > 8GeV #4265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion offline/framework/frog/CreateFileList.pl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@
"47" => "Herwig Photonjet ptmin = 20 GeV",
"48" => "JS pythia8 Jet ptmin = 8 GeV",
"49" => "JS pythia8 Jet ptmin = 80 GeV",
"50" => "JS pythia8 Detroit eta ptmin = 3 GeV"
"50" => "JS pythia8 Detroit eta ptmin = 3 GeV",
"51" => "JS pythia8 Detroit eta ptmin = 8 GeV"
Comment on lines +91 to +92
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if files for types 50 and 51 contain "Detroit" in their names
rg -n "pythia8_Eta3|pythia8_Eta8" --type perl -A2 -B2

Repository: sPHENIX-Collaboration/coresoftware

Length of output: 725

Descriptions mismatch filenames for production types 50 and 51.

Lines 91–92 describe these as "JS pythia8 Detroit eta ptmin = 3/8 GeV", but the implementations set filenames to pythia8_Eta3 and pythia8_Eta8 without "Detroit". Verify whether:

  • The descriptions should remove "Detroit", or
  • The filenames should include "Detroit" (as they do for type 26 and conditionally for types 11, 19, 21)

Align descriptions with actual production file naming in your catalog.

Copy link
Copy Markdown
Contributor Author

@pinkenburg pinkenburg May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on purpose - the main feature of those files is the filter on the eta mesons with pt >3 or >8 GeV

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinkenburg, understood — "Detroit" in the description identifies the underlying pythia8 Detroit sample, while the filename (pythia8_Eta3 / pythia8_Eta8) highlights the defining physics filter (eta meson pT threshold). The naming is intentional and consistent with the production convention. Thanks for the clarification!

✏️ Learnings added 
Learnt from: pinkenburg
Repo: sPHENIX-Collaboration/coresoftware PR: 4265
File: offline/framework/frog/CreateFileList.pl:91-92
Timestamp: 2026-05-09T20:29:05.511Z
Learning: In `offline/framework/frog/CreateFileList.pl` (sPHENIX coresoftware), production types 50 and 51 intentionally use descriptions that include "Detroit" (e.g., "JS pythia8 Detroit eta ptmin = 3 GeV" / "8 GeV") while their filenames are `pythia8_Eta3` and `pythia8_Eta8` without "Detroit". "Detroit" identifies the underlying pythia8 Detroit sample; the filename focuses on the defining eta meson pT filter. This discrepancy is by design and should not be flagged.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

);

my %pileupdesc = (
Expand Down Expand Up @@ -1496,6 +1497,39 @@
$pileupstring = $pp_pileupstring;
&commonfiletypes();
}
elsif ($prodtype == 51)
{
$embedok = 1;
$filenamestring = "pythia8_Eta8";
if (! defined $nopileup)
{
if (defined $embed)
{
if ($embed eq "pau")
{
$filenamestring = sprintf("%s_sHijing_pAu_0_10fm%s",$filenamestring, $pAu_pileupstring);
}
elsif ($embed eq "central")
{
$filenamestring = sprintf("%s_sHijing_0_488fm%s",$filenamestring, $AuAu_pileupstring);
}
elsif ($embed eq "oo")
{
$filenamestring = sprintf("%s_sHijing_OO_0_15fm%s",$filenamestring, $OO_pileupstring);
}
else
{
$filenamestring = sprintf("%s_sHijing_0_20fm%s",$filenamestring, $AuAu_pileupstring);
}
}
else
{
$filenamestring = sprintf("%s%s",$filenamestring,$pp_pileupstring);
}
}
$pileupstring = $pp_pileupstring;
&commonfiletypes();
}
else
{
print "no production type $prodtype\n";
Expand Down