Add integration tests for upstream token refresh#4133
Open
Conversation
Verify the UpstreamTokenService end-to-end against a real auth server with mockoidc, covering: valid token retrieval, transparent refresh of expired tokens, session-not-found, and missing refresh token error paths. Expose the authServer on testServer so integration tests can access IDPTokenStorage() and UpstreamTokenRefresher(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4133 +/- ##
==========================================
+ Coverage 68.13% 68.99% +0.86%
==========================================
Files 461 461
Lines 46704 46559 -145
==========================================
+ Hits 31821 32123 +302
+ Misses 12105 11955 -150
+ Partials 2778 2481 -297 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify the UpstreamTokenService end-to-end against a real auth server with mockoidc, covering: valid token retrieval, transparent refresh of expired tokens, session-not-found, and missing refresh token error paths.
Expose the authServer on testServer so integration tests can access IDPTokenStorage() and UpstreamTokenRefresher().
The bulk of the functionality was contributed by an external contributor (thanks!), these follow-ups are just to make life easier for us from the maintenance point of view.