Fix potential memory corruption in CachedCompilation.Iterator
#2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new experimental compiler feature `CheckImplementationOnly` enables type-checking the use of `@_implementationOnly` imports when building without library-evolution. I tried enabling this check on the driver project and it reported one potential issue that I hope to fix here. The issue is a property in a struct with the static type of `CSwiftScan.swiftscan_cached_compilation_t` where `CSwiftScan` is `@_implementationOnly` imported. This means that clients using this structs wouldn't see the right memory layout information unless they import `CSwiftScan` too. This may not have been an issue in practice if the type was used only within the same module. I'm suggesting a fix here. Keeping a reference to `CachedCompilation` should be safe as it's a class that hides the memory layout from the clients. We should adopt `CheckImplementationOnly` in the driver once it's completed, some early versions of it were too strict.
Contributor
|
@swift-ci please test |
Contributor
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new experimental compiler feature
CheckImplementationOnlyenables type-checking the uses of@_implementationOnlyimports when building without library-evolution. I tried enabling this check on the driver project and it reported one potential issue, this PR should address it.The issue is on a property in a struct with the static type of
CSwiftScan.swiftscan_cached_compilation_twhereCSwiftScanis@_implementationOnlyimported. This means that clients using this struct wouldn't see the right memory layout information unless they importCSwiftScantoo. This may not have been an issue in practice if the type was used only within the same module.I'm suggesting a fix here. Keeping a reference to
CachedCompilationshould be safe as it's a class that hides the memory layout from the clients.We should adopt
CheckImplementationOnlyin the driver once it's completed, some early versions of it were too strict.