Skip to content

Fix potential memory corruption in CachedCompilation.Iterator #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xymus merged 1 commit into from
Dec 11, 2025
Merged

Fix potential memory corruption in CachedCompilation.Iterator #2043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Sources/SwiftDriver/SwiftScan/SwiftScanCAS.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,18 @@ extension CachedCompilation: Sequence {
public struct Iterator: IteratorProtocol {
public typealias Element = CachedOutput
let limit: UInt32
let ptr: swiftscan_cached_compilation_t
let lib: SwiftScan
let sequence: CachedCompilation
var idx: UInt32 = 0
public mutating func next() -> CachedOutput? {
guard idx < self.limit else { return nil }
let output = self.lib.api.swiftscan_cached_compilation_get_output(self.ptr, idx)
let output = self.sequence.lib.api.swiftscan_cached_compilation_get_output(self.sequence.ptr, idx)
idx += 1
// output can never be nil.
return CachedOutput(output!, lib: self.lib)
return CachedOutput(output!, lib: self.sequence.lib)
}
}
public func makeIterator() -> Iterator {
return Iterator(limit: self.count, ptr: self.ptr, lib: self.lib)
return Iterator(limit: self.count, sequence: self)
}
}

Expand Down
Loading