修复 SQL 编辑器表名高亮丢失 - #8944
Merged
Merged
Conversation
initialize decorations to Decoration.none in the constructor so the !tree fallback can never surface undefined into the codemirror decoration pipeline, and gate the full-document prewarm behind a one-shot per-document flag so post-edit refreshes return to visible-range computation
Owner
|
Thanks — both mechanisms in this PR match the two root causes of #8942. I pushed one follow-up commit (
Both existing specs stay green (22/22 locally). |
Owner
|
Thanks for the contribution! Merged in 6694e43, will be released in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
SQL 编辑器中的有效表名在部分内置主题或长 SQL 文件中没有稳定显示表名颜色:滚动后可能退化为普通文本颜色,切换标签后也可能出现高亮缺失。
修复
验证
pnpm exec vitest run apps/desktop/src/lib/__tests__/editorThemes.spec.ts apps/desktop/src/lib/__tests__/editor/queryEditorSemanticHighlightPerformance.spec.ts:21 项通过。pnpm typecheck:通过。query_12.sql滚动前后表名保持橙色高亮。Fixes #8942