Fix schedule create/update dropping priority/fairness flags#1085
Open
NasitSony wants to merge 1 commit into
Open
Fix schedule create/update dropping priority/fairness flags#1085NasitSony wants to merge 1 commit into
NasitSony wants to merge 1 commit into
Conversation
toScheduleAction() called buildStartOptions() which correctly populated opts.Priority, but the resulting ScheduleWorkflowAction struct did not include the Priority field, silently discarding priority/fairness settings. Changes: - Add Priority: opts.Priority to ScheduleWorkflowAction in toScheduleAction() - Add Priority field to printableSchedule struct - Extract and display Priority in describeResultToPrintable() when action is ScheduleWorkflowAction Fixes temporalio#1028
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toScheduleAction() called buildStartOptions() which correctly populated opts.Priority, but the resulting ScheduleWorkflowAction struct did not include the Priority field, silently discarding priority/fairness settings.
Changes:
Fixes #1028
Related issues
Closes #1028
What changed?
Priority: opts.PrioritytoScheduleWorkflowActionstruct in
toScheduleAction()so priority/fairness flagsare no longer silently discarded
Priorityfield toprintableSchedulestructdescribeResultToPrintable()so
schedule describetext output shows priority when setChecklist
Stability
Design
Tests
Manual tests
Setup
Happy path
Expected: priority field visible in text output
Error case
Composition
Priority field now visible in describe output.