Skip to content

Fix schedule create/update dropping priority/fairness flags #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NasitSony wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix schedule create/update dropping priority/fairness flags #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/temporalcli/commands.schedule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
schedpb "go.temporal.io/api/schedule/v1"
"go.temporal.io/api/workflowservice/v1"
"go.temporal.io/sdk/client"
"go.temporal.io/sdk/temporal"
)

type printableSchedule struct {
Expand All @@ -35,6 +36,7 @@ type printableSchedule struct {
OverlapPolicy enumspb.ScheduleOverlapPolicy // describe only
CatchupWindow string // describe only
PauseOnFailure bool // describe only
Priority *temporal.Priority `cli:",cardOmitEmpty"` // describe only
// Schedule.State
Notes string `cli:",cardOmitEmpty"`
Paused bool
Expand Down Expand Up @@ -74,6 +76,14 @@ func describeResultToPrintable(id string, desc *client.ScheduleDescription) *pri
}
// Schedule.Action
out.Action = desc.Schedule.Action

// Extract priority from workflow action if present
if workflowAction, ok := desc.Schedule.Action.(*client.ScheduleWorkflowAction); ok {
if workflowAction.Priority != (temporal.Priority{}) {
out.Priority = &workflowAction.Priority
}
}

// Schedule.Spec
specToPrintable(out, desc.Schedule.Spec)
// Schedule.Policy
Expand Down Expand Up @@ -273,6 +283,7 @@ func toScheduleAction(sw *SharedWorkflowStartOptions, i *PayloadInputOptions) (c
Memo: opts.Memo,
StaticSummary: opts.StaticSummary,
StaticDetails: opts.StaticDetails,
Priority: opts.Priority,
}
if action.Args, err = i.buildRawInput(); err != nil {
return nil, err
Expand Down