feat: enable to emit activation events on all language files #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've tested the functionality and it seems this PR should be good to go. Could you please give it a quick review @azu? |
azu
reviewed
Mar 24, 2025
Member
azu
left a comment
azu
left a comment
There was a problem hiding this comment.
It would be helpful if you could designate me as a reviewer so I can easily notice.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request cherry-picks a previous change to enable the emission of activation events for textlint on all language files. Key changes include:
- Adding an activate function to update the status bar based on the language of the active editor.
- Changing the notification for the server running state from updating a tooltip to using an information message.
- Adjusting type usage for retrieving the "languages" configuration.
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/textlint/src/status.ts | Added activate method, updated serverRunning handling, and modified updateWith logic. |
| packages/test/testtest.py | Introduced a TODO comment indicating a non-validated target. |
| packages/test/testtest.js | Introduced a TODO comment indicating a validated target. |
| packages/textlint/src/extension.ts | Added a generic type and default value for the "languages" configuration. |
Files not reviewed (3)
- packages/test/.textlintrc: Language not supported
- packages/test/.vscode/settings.json: Language not supported
- packages/textlint/package.json: Language not supported
Co-authored-by: azu <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: azu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick of taichi/vscode-textlint#71.