Skip to content

feat: enable to emit activation events on all language files #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2025
Merged

feat: enable to emit activation events on all language files #8

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddeb106
allow activation events on user selected language files of all
iku12phycho Mar 9, 2024
17209b9
visible textlint targeted file at status bar
iku12phycho Mar 9, 2024
7c13b49
style: add newlines at end of files for POSIX compliance
3w36zj6 Mar 24, 2025
89dfce6
refactor: apply suggestion
3w36zj6 Mar 25, 2025
9099a61
fix: correct spelling error
3w36zj6 Mar 25, 2025
c4c9368
refactor: simplify status bar visibility logic
3w36zj6 Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/test/.textlintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
{
"plugins": {
"html": true,
"html": {
"extensions": [
".js"
]
},
"latex2e": true
},
"filters": {},
Expand Down
11 changes: 10 additions & 1 deletion packages/test/.vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
{
"textlint.run": "onType",
"textlint.autoFixOnSave": false,
"textlint.trace": "verbose"
"textlint.trace": "verbose",
"textlint.languages": [
"markdown",
"plaintext",
"html",
"tex",
"latex",
"doctex",
"javascript"
]
}
1 change: 1 addition & 0 deletions packages/test/testtest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// TODO: This is a validated target.
1 change: 1 addition & 0 deletions packages/test/testtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# TODO: This is NOT a validated target.
13 changes: 2 additions & 11 deletions packages/textlint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,7 @@
}
},
"activationEvents": [
"onLanguage:html",
"onLanguage:plaintext",
"onLanguage:markdown",
"onLanguage:latex",
"onLanguage:tex",
"onLanguage:pdf",
"onLanguage:django-txt",
"onLanguage:django-html",
"onLanguage:doctex",
"onLanguage:restructuredtext",
"onLanguage",
"onCommand:textlint.showOutputChannel",
"onCommand:textlint.createConfig",
"onCommand:textlint.executeAutofix"
Expand Down Expand Up @@ -148,7 +139,7 @@
"webpack-cli": "^4.9.1"
},
"engines": {
"vscode": "^1.61.0"
"vscode": "^1.74.0"
},
"icon": "textlint-icon_128x128.png",
"galleryBanner": {
Expand Down
2 changes: 1 addition & 1 deletion packages/textlint/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ function configureAutoFixOnSave(client: LanguageClient) {
disposeAutoFixOnSave();

if (auto) {
const languages = new Set(getConfig("languages"));
const languages = new Set(getConfig<string[]>("languages", []));
autoFixOnSave = workspace.onWillSaveTextDocument((event) => {
const doc = event.document;
const target = getConfig("targetPath", null);
Expand Down
24 changes: 18 additions & 6 deletions packages/textlint/src/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,20 @@ export class StatusBar {
this._delegate.hide();
}
}
activate(languageId: string) {
if (languageId === "") {
return;
}

if (-1 !== this._supports.indexOf(languageId)) {
this._delegate.color = "";
this._delegate.tooltip =
"need to restart this extension or check this extension setting and .textlintrc if textlint is not working.";
} else {
this._delegate.color = "#818589";
this._delegate.tooltip = `textlint is inanctive on ${languageId}.`;
}
}

get status(): Status {
return this._status;
Expand All @@ -73,7 +87,7 @@ export class StatusBar {

set serverRunning(sr: boolean) {
this._serverRunning = sr;
this._delegate.tooltip = sr ? "textlint server is running." : "textlint server stopped.";
window.showInformationMessage(sr ? "textlint server is running." : "textlint server stopped.");
this.update();
}

Expand All @@ -83,11 +97,9 @@ export class StatusBar {

updateWith(editor: TextEditor) {
this._delegate.text = this.status.label;
this.show(
this.serverRunning === false ||
this._status !== Status.OK ||
(editor && 0 < this._supports.indexOf(editor.document.languageId))
);
const languageId = editor?.document.languageId ?? "";
this.activate(languageId);
this.show(this.serverRunning === false || this._status !== Status.OK || -1 !== this._supports.indexOf(languageId));
}

startProgress() {
Expand Down