docs: add rust-test-hygiene skill capturing Phase 1-4 lessons - #131
Merged
Ziinc merged 2 commits intoJul 30, 2026
Merged
Conversation
Several clusters of tests differed only in setup inputs and expected outcomes (remote sync status variants, merge/squash-with-empty-commits variants, PTY line-filtering/ANSI-stripping cases). Consolidating them into single parameterized tests keeps all original assertions while cutting repetitive boilerplate.
Encodes the standards applied across the Rust test-suite cleanup (assert real treq behavior, reuse TestRepo helpers, avoid cross-file duplication, prefer table-driven tests over copy-pasted clusters) as a reusable Claude Code skill for future test authoring/review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 5 (final phase) of the Rust test-suite cleanup effort (stacked on #128, which now includes the merged Phase 4 table-driven-merge work). Adds
.claude/skills/rust-test-hygiene/SKILL.md, a reusable skill so future Rust test changes in this repo apply the same standards as the cleanup, instead of it being a one-off pass:#[cfg(test)]-only helper with no production caller.TestRepohelpers fromsrc-tauri/tests/e2e_test_helpers.rsinstead of hand-rolled setup.Vecof cases —rstestisn't a dependency today).Modeled on the structure/frontmatter of this repo's existing skills (e.g.
app-qa,pr-annotate), with concrete examples pulled from the actual diffs in Phases 1-4.Test plan
Generated by Claude Code