Skip to content

updated the react render, to use reactDOM.render#263

Open
sbrady wants to merge 2 commits into
trulia:masterfrom
sbrady:master
Open

updated the react render, to use reactDOM.render#263
sbrady wants to merge 2 commits into
trulia:masterfrom
sbrady:master

Conversation

@sbrady

@sbrady sbrady commented Jun 3, 2016

Copy link
Copy Markdown

No description provided.

@jdcantrell

Copy link
Copy Markdown
Contributor

Nice! Do you think it'd be helpful to also change <script type=\"text/jsx\" to <script type=\"text/babel\">? I started to make this change a week ago and then got distracted.

@sbrady

sbrady commented Jun 12, 2016

Copy link
Copy Markdown
Author

yes I think so, I'll do that.

I am not sure why the Travis build failed

@sbrady

sbrady commented Jun 13, 2016

Copy link
Copy Markdown
Author

Seems like this might be a little tricky, see: babel/babel-standalone#15

Although version 5 still supports in browser transformations.
<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.23/browser.min.js"></script>
should we document this somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants