Skip to content

updated the react render, to use reactDOM.render #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbrady wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated the react render, to use reactDOM.render #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8464814
updated the react render, to use reactDOM.render
Jun 3, 2016
1ac39ea
start using babel for react examples
sbrady Jun 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/hologram/code_example_renderer/renderers/react_renderer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
div_id = SecureRandom.hex(10)
[
"<div id=\"#{div_id}\"></div>",
"<script type=\"text/jsx\">",
" React.render(",
"<script type=\"text/babel\">",
" ReactDOM.render(",
" #{code.strip},",
" document.getElementById('#{div_id}')",
" );",
Expand Down
2 changes: 1 addition & 1 deletion lib/template/code_example_templates/jsx_example_template.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<script type='text/jsx'><%= rendered_example %></script>
<script type='text/babel'><%= rendered_example %></script>
<div class="codeBlock jsExample">
<div class="highlight">
<pre><%= code_example %></pre>
Expand Down
6 changes: 3 additions & 3 deletions spec/block_code_renderer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"<div class=\"codeExample\">",
" <div class=\"exampleOutput\">",
" <div id=\"#{div_id}\"></div>",
"<script type=\"text/jsx\">",
" React.render(",
"<script type=\"text/babel\">",
" ReactDOM.render(",
" <ReactExample property=\"value\">Example</ReactExample>,",
" document.getElementById('#{div_id}')",
" );",
Expand Down Expand Up @@ -237,7 +237,7 @@
let(:code) { '$(document).ready(function () { React.render(<div className="foo"></div>) });' }

it "inserts the code into the docs so that it will run and make the example work" do
expect(subject).to include "<script type='text/jsx'>$(document).ready(function () { React.render(<div className=\"foo\"></div>) });</script>"
expect(subject).to include "<script type='text/babel'>$(document).ready(function () { React.render(<div className=\"foo\"></div>) });</script>"
end

it { is_expected.to include [
Expand Down