Cope with invalid input without crashing #191
Conversation
Signed-off-by: Emmanuel Dreyfus <[email protected]>
| if (token == NULL) | ||
| return ARC_STAT_INVALID; | ||
|
|
There was a problem hiding this comment.
This cannot happen. There will always be an initial token, because the case where the string is empty returns before this call.
| if (token == NULL) | ||
| return ARC_STAT_INVALID; |
There was a problem hiding this comment.
This was already fixed in #83 ; the develop branch (while itself having some major unaddressed issues) is a fair bit ahead of the default branch.
You might also be interested in https://github.com/flowerysong/OpenARC/, which incorporates fixes for all known issues and adds some additional features.
There was a problem hiding this comment.
@manu0401 Since you've pushed this patch to NetBSD, I should maybe be a bit more strident: this change is incorrect. If no second token is found the code should default to simple canonicalization, as is done in the already existing fix that I pointed you at. See the definition of c in https://www.rfc-editor.org/rfc/rfc6376#section-3.5
There was a problem hiding this comment.
Thank you for the reminder. I note I have to look at it again.
manu0401
changed the title
2 participants
No description provided.