Skip to content

Cope with invalid input without crashing #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manu0401 wants to merge 1 commit into from
Closed

Cope with invalid input without crashing #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libopenarc/arc-canon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,16 +2135,20 @@ arc_parse_canon_t(unsigned char *tag, arc_canon_t *hdr_canon,
return ARC_STAT_INVALID;

token = strtok_r(tag, "/", &last);
if (token == NULL)
return ARC_STAT_INVALID;

Comment on lines +2138 to +2140
Copy link
Contributor

@flowerysong flowerysong Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot happen. There will always be an initial token, because the case where the string is empty returns before this call.

code = arc_name_to_code(canonicalizations, token);

if (code == -1)
return ARC_STAT_INVALID;

*hdr_canon = (arc_canon_t) code;

token = strtok_r(NULL, "/", &last);
code = arc_name_to_code(canonicalizations, token);
if (token == NULL)
return ARC_STAT_INVALID;

code = arc_name_to_code(canonicalizations, token);
if (code == -1)
return ARC_STAT_INVALID;

Expand Down