Skip to content

Add no-op skeleton for verifyPeerReview CLI#76

Merged
roryabraham merged 6 commits into
mainfrom
rory-peer-review-01-skeleton
Jul 3, 2026
Merged

Add no-op skeleton for verifyPeerReview CLI#76
roryabraham merged 6 commits into
mainfrom
rory-peer-review-01-skeleton

Conversation

@roryabraham

@roryabraham roryabraham commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Details

Phase 1 of splitting up #64 — introduces the first TypeScript code and package.json in this repo, with only CLI arg parsing and a no-op body. No tooling (typecheck/lint/prettier/tests) or real logic yet; those land in follow-up PRs.

Related Issues

For https://github.com/Expensify/Expensify/issues/636197

Manual Tests

  1. Run cd GitHub-Actions && nvm use && npm install.
  2. Run npm run verify-peer-review -- --owner Expensify --repo Auth --pull-request-number 12345 --base-ref main.
  3. Confirm the script prints the "Always passes for now." message and exits 0.
  4. Run npm run verify-peer-review with no arguments.
  5. Confirm the script prints a CLI usage/parsing error for missing required args and exits non-zero.

Co-authored-by: Cursor <cursoragent@cursor.com>
roryabraham and others added 5 commits July 2, 2026 17:31
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@roryabraham roryabraham marked this pull request as ready for review July 3, 2026 00:37
@roryabraham roryabraham requested review from grgia and rafecolton July 3, 2026 00:38
@roryabraham roryabraham merged commit d5cd345 into main Jul 3, 2026
4 checks passed
@roryabraham roryabraham deleted the rory-peer-review-01-skeleton branch July 3, 2026 03:32
roryabraham added a commit that referenced this pull request Jul 9, 2026
Integrate the split peer-review infrastructure PRs (#76-#81) while
keeping the branch's verifyPeerReview implementation and tests.

Conflict resolution favors main for tooling (Oxfmt, ESLint, CI
workflows, pull_request_target workflow) and keeps branch logic for
the peer review script, libs, and policy tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants