[workspace] Upgrade usockets_internal and uwebsockets_internal #23809
Conversation
Remove the version pin due to upstream regression to enable future upgrades, and remove a patch which has been released upstream.
|
@drake-jenkins-bot linux-noble-unprovisioned-gcc-wheel-experimental-release please. |
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
+a:@jwnimmer-tri to use the experimental wheel artifact and test a deployment on Deepnote. Thank you (and fingers crossed...)!
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee)
|
For my reference: |
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee)
a discussion (no related file):
Deepnote is still broken with this bump:
From /var/log/nginx/error.log:
2025/11/20 18:31:34 [error] 1781#1781: *33 connect() failed (111: Connection refused) while connecting to upstream, client: 10.236.48.173, server: _, request: "GET /7000/ HTTP/1.1", upstream: "http://127.0.0.1:7000/", host: "2edde83b-1de9-45b6-be0e-ea8e37feabc8.deepnoteproject.com"
It is not clear to me if this is the same error as last time. It seems slightly different. In any case, there is still some error.
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Deepnote is still broken with this bump:
From
/var/log/nginx/error.log:2025/11/20 18:31:34 [error] 1781#1781: *33 connect() failed (111: Connection refused) while connecting to upstream, client: 10.236.48.173, server: _, request: "GET /7000/ HTTP/1.1", upstream: "http://127.0.0.1:7000/", host: "2edde83b-1de9-45b6-be0e-ea8e37feabc8.deepnoteproject.com"It is not clear to me if this is the same error as last time. It seems slightly different. In any case, there is still some error.
Knowing total scratch about usockets/uwebsockets (and little networking in general...), but from some quick searching.
Is it possible we need extra stuff in our nginx-meshcat-proxy.conf? From https://ajmaradiaga.com/Allowing-web-sockets-when-using-NGINX-as-reverse-proxy/ I'm seeing proxy_set_header, proxy_http_version, etc.
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee)
a discussion (no related file):
Previously, tyler-yankee (Tyler Yankee) wrote…
Knowing total scratch about usockets/uwebsockets (and little networking in general...), but from some quick searching.
Is it possible we need extra stuff in our
nginx-meshcat-proxy.conf? From https://ajmaradiaga.com/Allowing-web-sockets-when-using-NGINX-as-reverse-proxy/ I'm seeingproxy_set_header,proxy_http_version, etc.
Maybe. I'll let y'all poke and repro and figure it out.
Notes for repro:
(1) Currently in our Deepnote we are using the Debian Bullseye (2021) version of nginx (1.18 -- https://packages.debian.org/bullseye/nginx). We could probably upgrade that to Bookworm (1.22 -- https://packages.debian.org/bookworm/nginx) if it helps solve the problem.
(2) To see the config we're currently running, check https://drake.mit.edu/release_playbook.html and find the mention of /etc/nginx/sites-available/deepnote-meshcat-proxy.
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee)
tools/workspace/usockets_internal/repository.bzl line 15 at r1 (raw file):
NOTE: Do not upgrade without testing the tutorials on Deepnote. See #18289. """,
BTW we should remove this comment as part of the upgrade. The caution was about re-introducing the regression, which (once this is fixed) is no longer a hazard.
Ditto below.
Code quote:
upgrade_advice = """
NOTE: Do not upgrade without testing the tutorials on Deepnote. See
#18289.
""",2 participants
Remove the version pin due to upstream regression to enable future upgrades, and remove a patch which has been released upstream.
Closes #17910.
This change is