Skip to content

[workspace] Upgrade usockets_internal and uwebsockets_internal #23809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tyler-yankee wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −43
Draft

[workspace] Upgrade usockets_internal and uwebsockets_internal #23809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tools/workspace/new_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@
"clang_cindex_python3_internal", # Uses a non-default branch.
"mosek", # Requires special, non-automated care during upgrades.
"pybind11", # Uses a non-default branch.
"usockets_internal", # Pinned due to upstream regression.
"uwebsockets_internal", # Pinned due to upstream regression.
]

# These repositories cannot be auto-upgraded. When checking for new releases,
Expand Down
8 changes: 4 additions & 4 deletions tools/workspace/usockets_internal/repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ def usockets_internal_repository(
# of this cohort should be updated at the same time.
repository = "uNetworking/uSockets",
upgrade_advice = """
NOTE: Do not upgrade without testing the tutorials on Deepnote. See
Drake #18289. v0.8.5 was tested and showed the same symptoms.
NOTE: Do not upgrade without testing the tutorials on Deepnote. See
#18289.
""",
commit = "v0.8.1",
sha256 = "3b33b5924a92577854e2326b3e2d393849ec00beb865a1271bf24c0f210cc1d6", # noqa
commit = "v0.8.8",
sha256 = "d14d2efe1df767dbebfb8d6f5b52aa952faf66b30c822fbe464debaa0c5c0b17", # noqa
build_file = ":package.BUILD.bazel",
mirrors = mirrors,
)
30 changes: 0 additions & 30 deletions tools/workspace/uwebsockets_internal/patches/upstream/pr1828.patch
View file
Open in desktop

This file was deleted.

11 changes: 4 additions & 7 deletions tools/workspace/uwebsockets_internal/repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,11 @@ def uwebsockets_internal_repository(
# of this cohort should be updated at the same time.
repository = "uNetworking/uWebSockets",
upgrade_advice = """
NOTE: Do not upgrade without testing the tutorials on Deepnote. See
Drake #18289. v20.35.0 was tested and showed the same symptoms.
NOTE: Do not upgrade without testing the tutorials on Deepnote. See
#18289.
""",
commit = "v20.14.0",
sha256 = "15cf995844a930c9a36747e8d714b94ff886b6814b5d4e3b3ee176f05681cccc", # noqa
commit = "v20.74.0",
sha256 = "e1d9c99b8e87e78a9aaa89ca3ebaa450ef0ba22304d24978bb108777db73676c", # noqa
build_file = ":package.BUILD.bazel",
patches = [
":patches/upstream/pr1828.patch",
],
mirrors = mirrors,
)