Protocol 28 (CAP-0085) - #5965
Merged
Merged
Conversation
Re-pins stellar-xdr to the merged CAP-0085 commit 8d1c926a5e5d9167d0fc7327b5dad06dc1ec4fd7 (stellar-xdr#308) and enables the CAP_0085_EXECUTABLE_REF feature alongside CAP_0083 in the Makefile XDR_FEATURES list. Regenerates gxdr/ and xdr/ generated Go plus xdr/Stellar-contract.x, and re-applies the hand-written SCVal/ContractExecutable helpers for the new SCV_EXECUTABLE_TAG and CONTRACT_EXECUTABLE_EXTERNAL_REF arms. Supersedes closed stellar#5962 (which pinned the unmerged dmkozh fork).
This was referenced Jul 22, 2026
sisuresh
marked this pull request as ready for review
July 22, 2026 18:30
urvisavla
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XDR regeneration for Protocol 28 / CAP-0085 (external-ref contract executables).
stellar-xdr(MakefileXDR_COMMIT) to the merged CAP-0085 commit8d1c926a5e5d9167d0fc7327b5dad06dc1ec4fd7(Add CAP-85 XDR changes (gated) stellar-xdr#308).CAP_0085_EXECUTABLE_REFtoXDR_FEATURESalongsideCAP_0083.gxdr/xdr_generated.go,xdr/xdr_generated.go,xdr/xdr_views_generated.go,xdr/Stellar-contract.x, andxdr/xdr_commit_generated.txt.SCVal/ContractExecutablehelpers for the newSCV_EXECUTABLE_TAGandCONTRACT_EXECUTABLE_EXTERNAL_REFarms (xdr/scval.go,xdr/scval_test.go).Verification
ScValTypeScvExecutableTag,ContractExecutableExternalRef,ContractExecutableTypeContractExecutableExternalRef.go build ./...— green.go test ./xdr/...— green (XDR round-trip +TestCAP0085Equals).Chain
stellar-xdr).Draft SPIKE against
protocol-next.